-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#98 Increase granularity of context. #135
Draft
alexanderlazarev0
wants to merge
21
commits into
modern-python:main
Choose a base branch
from
alexanderlazarev0:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+985
−145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # that_depends/providers/context_resources.py # that_depends/providers/resources.py
lesnik512
reviewed
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #98
Split context into:
ContextResource
)API changes:
All API changes only come in the form of extending current functionality via methods or optional arguments. Except for:
To set the
global_context
when callingcontainer_context()
, one needs to explicitly pass it as a keyword arguments.Instead of:
Now one must use:
This makes the new API incompatible with the current version!
-> Hence, my suggestion is to release this with
2.0
Points of discussion:
I will leave comments to be discusses in this pull request.
Still TODO:
Implementation notes:
@lesnik512 I did some test approaches prior to this implementation. Keeping one
contextvars.ContextVar
for allContextResources
and modifying the dict is not really feasible since you would need todeepcopy()
the dict and its contents to the newly created context. In that case, one would need to look for a different solution fromcontextvars
.