Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3.13 #103

Merged
merged 7 commits into from
Dec 17, 2024
Merged

python 3.13 #103

merged 7 commits into from
Dec 17, 2024

Conversation

lesnik512
Copy link
Member

No description provided.

@lesnik512 lesnik512 linked an issue Oct 13, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Lancetnik
Copy link
Contributor

Btw, do not forget to update pyproject as well

@Lancetnik
Copy link
Contributor

Btw, what is the actual project you are using? that-depends or modern-di?

@lesnik512
Copy link
Member Author

@Lancetnik for projects with sqlalchemy I'm moving to modern-di, because it's easier to manage orm sessions with scopes.

For simpler projects, where scopes are not needed, that-depends is used

@Lancetnik
Copy link
Contributor

@Lancetnik for projects with sqlalchemy I'm moving to modern-di, because it's easier to manage orm sessions with scopes.

For simpler projects, where scopes are not needed, that-depends is used

Sounds like a useless complexity, isn't it? Why are you using that-depends if modern-di is better? Do you thinking about slowly deprecation of the current lib to prior to modern-di?

@lesnik512
Copy link
Member Author

@Lancetnik

Sounds like a useless complexity, isn't it?

I'm panning to support both libraries, but with focus on promoting modern-di.

Why are you using that-depends

to be fair, I don't write new projects with that-depends. I had migrated some services to test modern-di in production and it works great. I think, some day we will migrate other services to modern-di as well

pyproject.toml Outdated Show resolved Hide resolved
@lesnik512 lesnik512 merged commit 20df7c3 into main Dec 17, 2024
6 checks passed
@lesnik512 lesnik512 deleted the feature/python3.13 branch December 17, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable python 3.13 support
2 participants