Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolchain upgrade to nightly-2025-01-28 #3855

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

feliperodri
Copy link
Contributor

@feliperodri feliperodri commented Jan 26, 2025

Resolves #3854.

This upgrade requires changes to remove RunCompiler due to the following changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@feliperodri feliperodri added [C] Internal Tracks some internal work. I.e.: Users should not be affected. Z-BenchCI Tag a PR to run benchmark CI labels Jan 26, 2025
@feliperodri feliperodri requested a review from a team as a code owner January 26, 2025 21:56
Copy link
Contributor

@carolynzech carolynzech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the PR description with the upstream changes that made these changes necessary (and fix the regression failures)?

@feliperodri feliperodri self-assigned this Jan 27, 2025
@feliperodri feliperodri changed the title Toolchain upgrade to nightly-2025-01-26 Toolchain upgrade to nightly-2025-01-27 Jan 27, 2025
@feliperodri
Copy link
Contributor Author

feliperodri commented Jan 27, 2025

Currently this is blocked by rust-lang/rust@0cffe5c. Expect to get this by tomorrow when upgrade to 2025-01-28. This is the same issue as described by rust-lang/rust#136086.

Signed-off-by: Felipe R. Monteiro <[email protected]>
@feliperodri feliperodri changed the title Toolchain upgrade to nightly-2025-01-27 Toolchain upgrade to nightly-2025-01-28 Jan 28, 2025
@feliperodri
Copy link
Contributor Author

This is the only significant regression in performance from the logs

2025-01-28T19:08:25.6886916Z benchcomp: WARNING: Benchmark 's2n-quic/quic/s2n-quic-platform/message::msg::tests::handle_get_set_test' regressed on metric 'solver_runtime' (22.01801 -> 118.50720600000001)
2025-01-28T19:08:25.6887928Z benchcomp: WARNING: Benchmark 'smol_str/check_new' regressed on metric 'solver_runtime' (80.13497000000001 -> 137.7696)

@celinval celinval added this pull request to the merge queue Jan 28, 2025
Merged via the queue into model-checking:main with commit ecbdb14 Jan 28, 2025
27 of 28 checks passed
@feliperodri feliperodri deleted the toolchain-upgrade branch January 28, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C] Internal Tracks some internal work. I.e.: Users should not be affected. Z-BenchCI Tag a PR to run benchmark CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toolchain upgrade to nightly-2025-01-25 failed
3 participants