Allow multiple annotations, but check for duplicate targets. #3808
+93
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this a duplicate of #3805? |
celinval
reviewed
Jan 2, 2025
celinval
approved these changes
Jan 6, 2025
feliperodri
approved these changes
Jan 23, 2025
| } | ||
| } | ||
|
|
||
| /// Adds the verified stub names to the `harness.verfied_stubs`. |
There was a problem hiding this comment.
Suggested change
| /// Adds the verified stub names to the `harness.verfied_stubs`. | |
| /// Adds the verified stub names to the `harness.verified_stubs`. |
|
@remi-delmas-3000 it seems CI is only failing due to formatting changes. Could you rebase it and merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3804.
Enables multiple
stub_verified(TARGET)annotations on a harness, but still detect and report duplicate targets.Adds positive and negative tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.