Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verify-std-check outcome check #3394

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

celinval
Copy link
Contributor

It looks like I used output instead of outcome variable.

I noticed that this PR should've failed the workflow but it didn't because of this mistake.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

It looks like I used `output` instead of `outcome` variable.
@celinval celinval requested a review from a team as a code owner July 29, 2024 18:09
Copy link
Contributor

@jaisnan jaisnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, should have caught this in my review. in any case, thanks!

Can we add a comment somewhere that all toolchain upgrade failures that are resolved manually should trigger a failure for this CI check?

@celinval
Copy link
Contributor Author

We currently have the following blob at the top of the workflow file:

# We expect toolchain updates to potentially break this workflow in cases where
# the version tracked in the `verify-rust-std` is not compatible with newer
# versions of the Rust toolchain.
#
# Changes unrelated to the toolchain should match the current status of main.

Do you have anything else in mind?

@jaisnan
Copy link
Contributor

jaisnan commented Jul 29, 2024

We currently have the following blob at the top of the workflow file:

# We expect toolchain updates to potentially break this workflow in cases where
# the version tracked in the `verify-rust-std` is not compatible with newer
# versions of the Rust toolchain.
#
# Changes unrelated to the toolchain should match the current status of main.

Do you have anything else in mind?

Just maybe a small clarification like ->

# We expect toolchain updates to potentially break this workflow in cases where
# the version tracked in the `verify-rust-std` is not compatible with newer 
# versions of the Rust toolchain. 
# For example, toolchain upgrade breaks such as 
# https://github.com/model-checking/kani/issues/3369.
#
# Changes unrelated to the toolchain should match the current status of main.

It's okay if this change is not added, this is purely for me because i like examples in comments.

@celinval
Copy link
Contributor Author

I agree that an example can be very helpful, but I'm not sure the PR you mentioned is a good reference. Maybe we can add a better link later.

The PR didn't actually fail the workflow, and the workflow logs themselves won't be available for more than a few days. So it might be confusing to use this as a reference.

@celinval celinval merged commit 7cd31aa into model-checking:main Jul 29, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants