Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade rust 1.79.0-nightly #4024

Merged
merged 4 commits into from
Jan 31, 2025
Merged

upgrade rust 1.79.0-nightly #4024

merged 4 commits into from
Jan 31, 2025

Conversation

jgreat
Copy link
Contributor

@jgreat jgreat commented Jan 30, 2025

Clean up Cargo.toml formatting and remove unnecessary feature.

  • warning: dev_dependencies is deprecated in favor of dev-dependencies and will not work in the 2024 edition
  • warning: default_features is deprecated in favor of default-features and will not work in the 2024 edition
  • warning: proc_macro is deprecated in favor of proc-macro and will not work in the 2024 edition
  • warning: the cargo feature named-profiles has been stabilized in the 1.57 release and is no longer necessary to be listed in the manifest

warning: non-local impl definition, they should be avoided as they go against expectation

#[derive(Zeroize)] and #[derive(Display)]

  • upgrade displaydoc to 0.2.5
  • upgrade zeroize to 1.8.1
  • upgrade zeroize_derive (lock files) to `1.4.21

warning: Compiler version doesn't include clang or GCC: "cc" "--version"

  • update cc (cc-rs) version to 1.2.10

error: usage of a legacy numeric method

help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants

  • crypto/message-cipher/src/aes_impl.rs
  • crypto/noise/src/cipher_state.rs
  • common/src/logger/loggers/mod.rs
  • crypto/digestible/derive/test/tests/structs.rs
  • crypto/digestible/tests/basic.rs
  • consensus/scp/src/msg.rs
  • transaction/builder/src/signed_contingent_input_builder.rs
  • transaction/builder/src/transaction_builder.rs
  • t3/connection/src/lib.rs
  • peers/src/connection.rs
  • mobilecoind-json/src/bin/main.rs
  • fog/sample-paykit/src/client.rs
  • mobilecoind-dev-faucet/src/lib.rs
  • fog/block_provider/src/mobilecoind.rs
  • mobilecoind/src/service.rs
  • fog/ingest/server/src/connection.rs

error: importing a legacy numeric constant

help: remove this import and use the associated constant from the primitive type instead

  • attest/core/src/ias/verify.rs

error: usage of a legacy numeric constant

help: use the associated constant instead

  • attest/core/src/ias/verify.rs

error: clamp-like pattern without using clamp function

  • attest/core/src/quote.rs

error: function cannot return without recursing

  • fog/ingest/enclave/api/src/error.rs

error: transmute used without annotations

help: consider adding missing annotations: transmute::<u32, mc_blockchain_types::BlockVersion>

  • ledger/db/src/ledger_db.rs

Copy link

⚠️ Downstream repo mobilecoinofficial/android-bindings failed to build. Check actions status for details.

Copy link

⚠️ Downstream repo mobilecoinofficial/full-service failed to build. Check actions status for details.

Copy link
Collaborator

@nick-mobilecoin nick-mobilecoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, if possible it would be good to only use the major version or the "0.x" version for 0 version crates, to minimize file changes when dependencies are updated in the future

account-keys/Cargo.toml Outdated Show resolved Hide resolved
account-keys/Cargo.toml Outdated Show resolved Hide resolved
consensus/service/src/background_work_queue.rs Outdated Show resolved Hide resolved
fog/sql_recovery_db/src/models.rs Outdated Show resolved Hide resolved
fog/view/protocol/src/user_rng_set.rs Outdated Show resolved Hide resolved
mobilecoind-dev-faucet/src/worker.rs Outdated Show resolved Hide resolved
sgx/build/Cargo.toml Outdated Show resolved Hide resolved
Copy link

⚠️ Downstream repo mobilecoinofficial/android-bindings failed to build. Check actions status for details.

Copy link

⚠️ Downstream repo mobilecoinofficial/full-service failed to build. Check actions status for details.

Copy link

⚠️ Downstream repo mobilecoinofficial/android-bindings failed to build. Check actions status for details.

Copy link

⚠️ Downstream repo mobilecoinofficial/full-service failed to build. Check actions status for details.

@jgreat jgreat merged commit be796e4 into main Jan 31, 2025
21 checks passed
@jgreat jgreat deleted the jgreat/rust-1-79-0-nightly branch January 31, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants