-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade rust 1.79.0-nightly #4024
Conversation
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, if possible it would be good to only use the major version or the "0.x" version for 0 version crates, to minimize file changes when dependencies are updated in the future
|
|
|
|
Clean up Cargo.toml formatting and remove unnecessary feature.
dev_dependencies
is deprecated in favor ofdev-dependencies
and will not work in the 2024 editiondefault_features
is deprecated in favor ofdefault-features
and will not work in the 2024 editionproc_macro
is deprecated in favor ofproc-macro
and will not work in the 2024 editionnamed-profiles
has been stabilized in the 1.57 release and is no longer necessary to be listed in the manifestwarning: non-local
impl
definition, they should be avoided as they go against expectation#[derive(Zeroize)]
and#[derive(Display)]
displaydoc
to 0.2.5zeroize
to 1.8.1zeroize_derive
(lock files) to `1.4.21warning: Compiler version doesn't include clang or GCC: "cc" "--version"
error: usage of a legacy numeric method
help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
error: importing a legacy numeric constant
help: remove this import and use the associated constant from the primitive type instead
error: usage of a legacy numeric constant
help: use the associated constant instead
error: clamp-like pattern without using clamp function
error: function cannot return without recursing
error: transmute used without annotations
help: consider adding missing annotations:
transmute::<u32, mc_blockchain_types::BlockVersion>