Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExtendedProductIdVerifier #39

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Conversation

nick-mobilecoin
Copy link
Collaborator

@nick-mobilecoin nick-mobilecoin commented Mar 9, 2023

Add ExtendedProductIdVerifier for verifying the ExtendedProductId in ReportBodys

@github-actions github-actions bot added the size/M Medium-sized PRs label Mar 9, 2023
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #39 (5c5209d) into nick/cpu_svn (1c4a61b) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           nick/cpu_svn      #39      +/-   ##
================================================
+ Coverage         95.39%   95.54%   +0.15%     
================================================
  Files                 2        2              
  Lines               738      764      +26     
================================================
+ Hits                704      730      +26     
  Misses               34       34              
Impacted Files Coverage Δ
verifier/src/lib.rs 90.51% <ø> (ø)
verifier/src/report_body.rs 99.31% <100.00%> (+0.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nick-mobilecoin nick-mobilecoin requested review from a team and samdealy and removed request for a team March 9, 2023 18:01
Copy link
Contributor

@samdealy samdealy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a PR description.

@nick-mobilecoin
Copy link
Collaborator Author

@nick-mobilecoin queued this pull request to merge with Graphite.

Base automatically changed from nick/cpu_svn to main March 14, 2023 20:59
@nick-mobilecoin nick-mobilecoin merged commit 3768eb5 into main Mar 14, 2023
@nick-mobilecoin nick-mobilecoin deleted the nick/extended-product-id branch March 14, 2023 20:59
@nick-mobilecoin
Copy link
Collaborator Author

@nick-mobilecoin merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Medium-sized PRs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants