Skip to content

Commit

Permalink
Fixes piranhacloud#4401 - Fix arquillian-protocol-servlet-jakarta dep…
Browse files Browse the repository at this point in the history
…endency for REST TCK (piranhacloud#4402)
  • Loading branch information
mnriem authored Dec 15, 2024
1 parent dd986fe commit cb65ecf
Show file tree
Hide file tree
Showing 9 changed files with 18 additions and 24 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/tck-coreprofile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -183,13 +183,13 @@ jobs:
run: mvn -B -DskipTests=true -ntp install
- name: Run TCK
run: |
cd external/tck/rest
cd external/coreprofile-tck/rest
mvn -B -ntp -T 1 verify
- name: Test Summary
uses: test-summary/action@v2
id: test_summary
with:
paths: "external/tck/rest/runner/target/failsafe-reports/**/TEST-*.xml"
paths: "external/coreprofile-tck/rest/runner/target/failsafe-reports/**/TEST-*.xml"
output: test-summary.md
if: always()
- name: Job Summary
Expand Down
5 changes: 0 additions & 5 deletions external/coreprofile-tck/annotations/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,6 @@

<name>Piranha - External - Core Profile TCK - Annotations - Project</name>

<properties>
<annotations.tck.version>3.0.0</annotations.tck.version>
<sigtest-maven-plugin.version>2.2</sigtest-maven-plugin.version>
</properties>

<modules>
<module>installer</module>
<module>runner</module>
Expand Down
7 changes: 7 additions & 0 deletions external/coreprofile-tck/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,15 @@
<packaging>pom</packaging>
<name>Piranha - External - Core Profile TCK - Project</name>
<properties>
<annotations.tck.version>3.0.0</annotations.tck.version>
<commons-httpclient.version>3.1</commons-httpclient.version>
<glassfish-client-ee11.version>1.6.1</glassfish-client-ee11.version>
<hamcrest.version>3.0</hamcrest.version>
<rest.tck.version>4.0.1</rest.tck.version>
<sigtest-maven-plugin.version>2.2</sigtest-maven-plugin.version>
</properties>
<modules>
<module>annotations</module>
<module>rest</module>
</modules>
</project>
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>cloud.piranha.external.tck.rest</groupId>
<groupId>cloud.piranha.external.coreprofiletck.rest</groupId>
<artifactId>project</artifactId>
<version>25.1.0-SNAPSHOT</version>
</parent>

<artifactId>piranha-external-tck-rest-installer</artifactId>
<artifactId>piranha-external-coreprofiletck-rest-installer</artifactId>
<packaging>pom</packaging>

<name>Piranha - External - TCK - REST - Installer</name>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,17 @@
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>cloud.piranha.external.tck</groupId>
<groupId>cloud.piranha.external.coreprofiletck</groupId>
<artifactId>project</artifactId>
<version>25.1.0-SNAPSHOT</version>
</parent>

<groupId>cloud.piranha.external.tck.rest</groupId>
<groupId>cloud.piranha.external.coreprofiletck.rest</groupId>
<artifactId>project</artifactId>
<packaging>pom</packaging>

<name>Piranha - External - TCK - REST - Project</name>
<name>Piranha - External - Core Profile TCK - REST - Project</name>

<properties>
<commons-httpclient.version>3.1</commons-httpclient.version>
<glassfish-client-ee11.version>1.6.1</glassfish-client-ee11.version>
<rest.tck.version>4.0.1</rest.tck.version>
</properties>

<modules>
<module>installer</module>
<module>runner</module>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>cloud.piranha.external.tck.rest</groupId>
<groupId>cloud.piranha.external.coreprofiletck.rest</groupId>
<artifactId>project</artifactId>
<version>25.1.0-SNAPSHOT</version>
</parent>

<artifactId>piranha-external-tck-rest-runner</artifactId>
<artifactId>piranha-external-coreprofiletck-rest-runner</artifactId>
<packaging>jar</packaging>
<name>Piranha - External - TCK - REST - Runner</name>

Expand Down Expand Up @@ -49,7 +49,7 @@
<dependency>
<groupId>org.jboss.arquillian.protocol</groupId>
<artifactId>arquillian-protocol-servlet-jakarta</artifactId>
<version>${arquillian.version}</version>
<version>${arquillian-jakarta.version}</version>
<scope>test</scope>
</dependency>
<dependency>
Expand All @@ -70,7 +70,7 @@
<dependency>
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest</artifactId>
<version>3.0</version>
<version>${hamcrest.version}</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down Expand Up @@ -110,7 +110,6 @@
<arquillian.launch>piranha</arquillian.launch>
<cts.harness.debug>true</cts.harness.debug>
<junit.log.traceflag>true</junit.log.traceflag>
<optional.tech.packages.to.ignore>jakarta.xml.bind</optional.tech.packages.to.ignore>
<porting.ts.url.class.1>ee.jakarta.tck.ws.rs.lib.implementation.sun.common.SunRIURL</porting.ts.url.class.1>
<servlet_adaptor>org.glassfish.jersey.servlet.ServletContainer</servlet_adaptor>
<webServerHost>localhost</webServerHost>
Expand Down
1 change: 0 additions & 1 deletion external/tck/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
<module>jsonb</module>
<module>jsonp</module>
<module>jwt</module>
<module>rest</module>
<module>server</module>
<module>wasp</module>
</modules>
Expand Down

0 comments on commit cb65ecf

Please sign in to comment.