Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Improve qdarkstyle logic #12491

Merged
merged 5 commits into from
Mar 12, 2024
Merged

MAINT: Improve qdarkstyle logic #12491

merged 5 commits into from
Mar 12, 2024

Conversation

larsoner
Copy link
Member

  1. Bump Qt binding minimum to 5.15, released almost 4 years ago. This in principle could be 6.0 but I know conda-forge doesn't have suitable bindings for it yet (PySide6 is in progress at least but does not provide a builtin event loop like PyQt6 does so matplotlib etc. do not behave as expected for plain python + plt.ion() users).
  2. Simplify logic of stylesheet setting by removing some version conditionals and short-circuiting when possible to reduce indentation. We now only need to warn when qdarkstyle < 3.2.3 (3.2.3 came out Nov '23) is used with a Qt6 variant

@larsoner
Copy link
Member Author

This fixes a failure currently in main so I'll mark for merge-when-green but happy to revise if you review and see issues @drammock

@larsoner larsoner enabled auto-merge (squash) March 12, 2024 20:43
@larsoner larsoner merged commit b752d2a into mne-tools:main Mar 12, 2024
30 checks passed
@larsoner larsoner deleted the darkstyle branch March 12, 2024 20:59
snwnde pushed a commit to snwnde/mne-python that referenced this pull request Mar 20, 2024
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants