Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes found by sphinx-lint #12487

Merged
merged 1 commit into from
Mar 9, 2024
Merged

fixes found by sphinx-lint #12487

merged 1 commit into from
Mar 9, 2024

Conversation

drammock
Copy link
Member

@drammock drammock commented Mar 8, 2024

I ran sphinx-lint on our mne/ and docs/ folders and this is what it turned up. Here's what it turned up that I didn't change:

  • I decided to ignore the "no newline at end of file" for all the towncrier files, since they're temporary anyway.
  • a couple of tests where we have TABS instead of spaces (in test_curry.py and test_montage.py) that are expected/necessary (they're multiline strings emulating a file format).

We could consider adding sphinx-lint as a precommit hook too.

@larsoner larsoner merged commit a622a46 into mne-tools:main Mar 9, 2024
31 of 32 checks passed
@larsoner
Copy link
Member

larsoner commented Mar 9, 2024

Thanks @drammock !

snwnde pushed a commit to snwnde/mne-python that referenced this pull request Mar 20, 2024
@drammock drammock deleted the sphinx-lint branch April 24, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants