Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for #12360 Replacing percent format with f-strings #12464

Merged
merged 48 commits into from
Mar 19, 2024
Merged

Fixes for #12360 Replacing percent format with f-strings #12464

merged 48 commits into from
Mar 19, 2024

Conversation

hasrat17
Copy link
Contributor

Reference issue

FIXES #12360

What does this implement/fix?

Replace percent format with format specifiers (f-strings)

Additional information

Used this command to capture percent format ruff check mne --config pyproject.toml --select UP031
Screenshot from 2024-02-27 02-04-43

@welcome Welcome
Copy link

welcome bot commented Feb 26, 2024

Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴

@hoechenberger
Copy link
Member

Thanks for your contribution, @hasrat17! There are numerous tests failing; this would need to be resolved before we can proceed here. Thanks!

@hasrat17
Copy link
Contributor Author

Hey @hoechenberger, This is my first contribution to open source; sorry for asking this, but can you please correct me if I am wrong? So I need to run this command pytest -m "not ultraslowtest" mne and check whether everything is passing. And the test case here, which is failing like this one, Tests / ubuntu-latest / pip-pre / 3.11 (pull_request) in details shows an extensive file, how to track the error from there to resolve it.
image

@hoechenberger
Copy link
Member

Hello, I won't have time to assist you here, sorry. But I'm sure some of the other developers will chime in 👍

larsoner
larsoner reviewed Feb 28, 2024
View reviewed changes
Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave a couple of hints, can you see if it can help you fix the rest of the errors?

@hasrat17 hasrat17 closed this Mar 2, 2024
@hasrat17 hasrat17 reopened this Mar 2, 2024
hasrat17 and others added 21 commits March 13, 2024 23:19
@hasrat17 @cbrnr
Update mne/io/base.py
3df0d6d 
Co-authored-by: Clemens Brunner <[email protected]>
@hasrat17 @cbrnr
Update mne/io/ctf/info.py
96473d9 
Co-authored-by: Clemens Brunner <[email protected]>
@hasrat17 @cbrnr
Update mne/utils/_testing.py
ff449dc 
Co-authored-by: Clemens Brunner <[email protected]>
@hasrat17 @cbrnr
Update mne/time_frequency/tfr.py
0d9f67b 
Co-authored-by: Clemens Brunner <[email protected]>
@hasrat17 @cbrnr
Update mne/time_frequency/_stockwell.py
d4ebdba 
Co-authored-by: Clemens Brunner <[email protected]>
@hasrat17 @cbrnr
Update mne/io/eyelink/tests/test_eyelink.py
5de4621 
Co-authored-by: Clemens Brunner <[email protected]>
@hasrat17 @cbrnr
Update mne/io/fieldtrip/utils.py
b0d3a71 
Co-authored-by: Clemens Brunner <[email protected]>
@hasrat17 @cbrnr
Update mne/io/kit/coreg.py
601bc0e 
Co-authored-by: Clemens Brunner <[email protected]>
@hasrat17 @cbrnr
Update mne/io/kit/coreg.py
a963fa1 
Co-authored-by: Clemens Brunner <[email protected]>
@hasrat17 @cbrnr
Update mne/label.py
c191822 
Co-authored-by: Clemens Brunner <[email protected]>
@hasrat17 @cbrnr
Update mne/label.py
63dc4c1 
Co-authored-by: Clemens Brunner <[email protected]>
@hasrat17 @cbrnr
Update mne/minimum_norm/time_frequency.py
1ff85cb 
Co-authored-by: Clemens Brunner <[email protected]>
@hasrat17 @cbrnr
Update mne/morph.py
c7cea63 
Co-authored-by: Clemens Brunner <[email protected]>
@hasrat17 @cbrnr
Update mne/preprocessing/artifact_detection.py
82d60dd 
Co-authored-by: Clemens Brunner <[email protected]>
@hasrat17 @cbrnr
Update mne/source_estimate.py
5099829 
Co-authored-by: Clemens Brunner <[email protected]>
@hasrat17 @cbrnr
Update mne/source_estimate.py
d2909e2 
Co-authored-by: Clemens Brunner <[email protected]>
@hasrat17 @cbrnr
Update mne/source_space/_source_space.py
c81d645 
Co-authored-by: Clemens Brunner <[email protected]>
@hasrat17 @cbrnr
Update mne/stats/cluster_level.py
e725efb 
Co-authored-by: Clemens Brunner <[email protected]>
@hasrat17
updated mne/simulation/source.py, git_archival
448088a
@hasrat17
Merge branch 'main' of https://github.com/hasrat17/mne-python
9d50ba4
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
4462cd1 
for more information, see https://pre-commit.ci
@larsoner larsoner added this to the 1.7 milestone Mar 14, 2024
@hasrat17 hasrat17 requested a review from cbrnr March 16, 2024 08:38
@hasrat17
Copy link
Contributor Author

Hey, @cbrnr @drammock @larsoner I have updated everything based on your suggestions. Can we merge this request?

larsoner
larsoner approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pushed a tiny commit to revert two little things, marking for merge when green, thanks in advance @hasrat17 !

@larsoner larsoner merged commit b8d9c17 into mne-tools:main Mar 19, 2024
30 checks passed
@welcome Welcome
Copy link

welcome bot commented Mar 19, 2024

🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪

snwnde pushed a commit to snwnde/mne-python that referenced this pull request Mar 20, 2024
@hasrat17 @cbrnr
@drammock @pre-commit-ci @larsoner @snwnde
Fixes for mne-tools#12360 Replacing percent format with f-strings (mn…
aa9e199 
…e-tools#12464)

Co-authored-by: Clemens Brunner <[email protected]>
Co-authored-by: Daniel McCloy <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Eric Larson <[email protected]>
@sappelhoff sappelhoff mentioned this pull request Jul 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drammock drammock drammock left review comments

@larsoner larsoner larsoner approved these changes

@cbrnr cbrnr Awaiting requested review from cbrnr cbrnr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

Replace percent format with format specifiers (f-strings)
5 participants
@hasrat17 @hoechenberger @larsoner @drammock @cbrnr