Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sphinx roles and parenthesis #12385

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Fix sphinx roles and parenthesis #12385

merged 1 commit into from
Jan 29, 2024

Conversation

mscheltienne
Copy link
Member

Fix nitpicks from #12326

@mscheltienne mscheltienne enabled auto-merge (squash) January 25, 2024 09:03
@mscheltienne
Copy link
Member Author

@larsoner The no-changelog-entry-needed is not sufficient to entirely skip the required Changelog / towncrier test which fails since this PR fixes a typo in another changelog entry. Maybe we can have the no-changelog-entry-needed be a full overwrite which disables this workflow?

@larsoner larsoner disabled auto-merge January 29, 2024 18:24
@larsoner larsoner merged commit 8419ca0 into mne-tools:main Jan 29, 2024
29 of 31 checks passed
@larsoner
Copy link
Member

Thanks @mscheltienne !

@mscheltienne mscheltienne deleted the nitpick branch January 29, 2024 18:25
snwnde pushed a commit to snwnde/mne-python that referenced this pull request Mar 20, 2024
@snwnde
Fix sphinx roles and parenthesis (mne-tools#12385)
3d85132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsoner larsoner Awaiting requested review from larsoner larsoner is a code owner

@drammock drammock Awaiting requested review from drammock drammock is a code owner

@agramfort agramfort Awaiting requested review from agramfort agramfort is a code owner

@dengemann dengemann Awaiting requested review from dengemann dengemann is a code owner

Assignees
No one assigned
Labels
no-changelog-entry-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mscheltienne @larsoner