-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): update preprocessing tutorial for using inst.pick() instead of pick_types() #12326
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
48cadad
chore: update preprocessing tutorial for using inst.pick() instead of…
btkcodedev 73bd9db
Merge pull request #1 from btkcodedev/chore/updatePreprocessDoc
btkcodedev b5cf780
Update tutorials/preprocessing/15_handling_bad_channels.py
btkcodedev f7c59cb
Update 15_handling_bad_channels.py
btkcodedev f54a065
Merge branch 'main' into main
16f6d6c
Update tutorials/preprocessing/15_handling_bad_channels.py
btkcodedev 4afcff2
Merge branch 'main' into main
btkcodedev ea31ce6
Update names.inc
btkcodedev b0da613
Create 12326.other.rst
btkcodedev 7818ee4
Merge pull request #3 from btkcodedev/patch-1
btkcodedev 808c9af
Merge pull request #2 from btkcodedev/patch-2
btkcodedev 173690b
Merge branch 'main' into main
btkcodedev 770fc3e
Update doc/changes/devel/12326.other.rst
btkcodedev 6a0db7e
Update names.inc
btkcodedev 2ed243a
Merge branch 'main' into main
btkcodedev 4fdd5a0
trigger cis
ad8c644
Merge branch 'main' into main
6f5408b
fix typo
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Updated the text in the preprocessing tutorial to use :class:`mne.io.Raw.pick()` instead of the legacy :class:`mne.io.Raw.pick_types()`, by :newcontrib:`btkcodedev`. | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -238,8 +238,9 @@ | |||||
fig.suptitle(title, size="xx-large", weight="bold") | ||||||
|
||||||
# %% | ||||||
# Note that we used the ``exclude=[]`` trick in the call to | ||||||
# :meth:`~mne.io.Raw.pick_types` to make sure the bad channels were not | ||||||
# Note that the method :meth:`~mne.io.Raw.pick()` default | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FYI parentheses get added automatically when you use the
Suggested change
|
||||||
# arguments includes ``exclude=()`` which ensures that bad | ||||||
# channels are not | ||||||
# automatically dropped from the selection. Here is the corresponding example | ||||||
# with the interpolated gradiometer channel; since there are more channels | ||||||
# we'll use a more transparent gray color this time: | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little surprised that these cross-refs worked; regardless, it's more accurate to mark these with the
:meth:
role since they're links to methods (not classes). The parentheses will get added automatically.