Fix unused parameters (#19)

- removed parameter names for known types - commented parameter names for string types - moved virtual method body from header to implementation file - moved cmakesettings to template - added more options to pedantic builds
mmahnic · Aug 31, 2023 · 0d9e50d · 0d9e50d
2 parents 94f6d59 + f0c552c
commit 0d9e50d
Show file tree

Hide file tree

Showing 13 changed files with 30 additions and 20 deletions.
diff --git a/.gitignore b/.gitignore
@@ -4,6 +4,8 @@ build-*/
 out/
 xdata/
 
+CMakeSettings.json
+
 *.swp
 *.*~
 ~*.*

diff --git a/CMakeSettings.json → CMakeSettings.json.in b/CMakeSettings.json → CMakeSettings.json.in
diff --git a/example/basic_action.cpp b/example/basic_action.cpp
@@ -25,7 +25,7 @@ int main( int argc, char** argv )
    params.add_parameter( operation, "--sum", "-s" )
          .nargs( 0 )
          .absent( std::make_pair( max, INT_MIN ) )
-         .action( [&]( auto& target, const std::string& value ) {
+         .action( [&]( auto& target, const std::string& /*value*/ ) {
             target = std::make_pair( sum, 0 );
          } )
          .help( "Sum the integers (default: find the max)" );

diff --git a/example/basic_command.cpp b/example/basic_command.cpp
@@ -30,7 +30,7 @@ class CmdAccumulatorOptions : public argumentum::CommandOptions
 public:
    using CommandOptions::CommandOptions;
 
-   void execute( const ParseResult& res ) override
+   void execute( const ParseResult& ) override
    {
       const auto& numbers = common->numbers;
       auto acc = accumulate( numbers.begin(), numbers.end(), operation.second, operation.first );
@@ -54,7 +54,7 @@ class CmdAccumulatorOptions : public argumentum::CommandOptions
       params.add_parameter( operation, "--sum", "-s" )
             .nargs( 0 )
             .absent( std::make_pair( max, INT_MIN ) )
-            .action( [&]( auto& target, const std::string& value ) {
+            .action( [&]( auto& target, const std::string& /*value*/ ) {
                target = std::make_pair( sum, 0 );
             } )
             .help( "Sum the integers (default: find the max)" );
@@ -76,7 +76,7 @@ class CmdEchoOptions : public argumentum::CommandOptions
       params.add_parameters( common );
    };
 
-   void execute( const ParseResult& res ) override
+   void execute( const ParseResult& ) override
    {
       for ( auto n : common->numbers )
          cout << n << " ";

diff --git a/example/basic_struct.cpp b/example/basic_struct.cpp
@@ -27,7 +27,7 @@ class AccumulatorOptions : public argumentum::Options
       params.add_parameter( operation, "--sum", "-s" )
             .nargs( 0 )
             .absent( std::make_pair( max, INT_MIN ) )
-            .action( [&]( auto& target, const std::string& value ) {
+            .action( [&]( auto& target, const std::string& /*value*/ ) {
                target = std::make_pair( sum, 0 );
             } )
             .help( "Sum the integers (default: find the max)" );

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
@@ -20,8 +20,8 @@ if ( ARGUMENTUM_BUILD_STATIC_LIBS )
    if( ARGUMENTUM_PEDANTIC )
       target_compile_options( ${static_library_name}
          PRIVATE
-         $<$<CXX_COMPILER_ID:GNU>:-Werror -Wall>
-         $<$<CXX_COMPILER_ID:MSVC>:/WX /permissive- /Za>
+         $<$<CXX_COMPILER_ID:GNU>:-Wall -Wextra -pedantic -Werror -Wl,--fatal-warnings>
+         $<$<CXX_COMPILER_ID:MSVC>:/W4 /WX /permissive- /Za>
          )
    endif()
 
@@ -46,8 +46,8 @@ if( ARGUMENTUM_IS_TOP_LEVEL )
    if( ARGUMENTUM_PEDANTIC )
       target_compile_options( ${internal_library_name}
          PRIVATE
-         $<$<CXX_COMPILER_ID:GNU>:-Werror -Wall>
-         $<$<CXX_COMPILER_ID:MSVC>:/WX /permissive- /Za>
+         $<$<CXX_COMPILER_ID:GNU>:-Wall -Wextra -pedantic -Werror -Wl,--fatal-warnings>
+         $<$<CXX_COMPILER_ID:MSVC>:/W4 /WX /permissive- /Za>
          )
    endif()
 endif()
diff --git a/src/argumentstream_impl.h b/src/argumentstream_impl.h
@@ -8,7 +8,7 @@
 
 namespace argumentum {
 
-ARGUMENTUM_INLINE void ArgumentStream::peek( std::function<EPeekResult( std::string_view )> fnPeek )
+ARGUMENTUM_INLINE void ArgumentStream::peek( std::function<EPeekResult( std::string_view )> )
 {}
 
 ARGUMENTUM_INLINE StdStreamArgumentStream::StdStreamArgumentStream(

diff --git a/src/optionpack.h b/src/optionpack.h
@@ -16,10 +16,7 @@ class Options
 {
 public:
    virtual ~Options() = default;
-   virtual void add_parameters( ParameterConfig& args )
-   {
-      // TODO (mmahnic): make method add_parameters( ParameterConfig) abstract.
-   }
+   virtual void add_parameters( ParameterConfig& args );
 
 #ifdef ARGUMENTUM_DEPRECATED_ATTR
 // Attributes are not handled well by clang-format so we use a macro.

diff --git a/src/optionpack_impl.h b/src/optionpack_impl.h
@@ -9,6 +9,9 @@
 
 namespace argumentum {
 
+void Options::add_parameters( ParameterConfig& )
+{}
+
 void Options::add_arguments( argument_parser& parser )
 {
    auto params = parser.params();
@@ -24,7 +27,7 @@ ARGUMENTUM_INLINE const std::string& CommandOptions::getName() const
    return mName;
 }
 
-ARGUMENTUM_INLINE void CommandOptions::execute( const ParseResult& result )
+ARGUMENTUM_INLINE void CommandOptions::execute( const ParseResult& )
 {}
 
 }   // namespace argumentum
diff --git a/src/parserconfig_impl.h b/src/parserconfig_impl.h
@@ -91,7 +91,7 @@ ARGUMENTUM_INLINE std::ostream* ParserConfig::Data::output_stream() const
 }
 
 ARGUMENTUM_INLINE std::shared_ptr<IFormatHelp> ParserConfig::Data::help_formatter(
-      const std::string& helpOption ) const
+      const std::string& /*helpOption*/ ) const
 {
    return mpHelpFormatter ? mpHelpFormatter : std::make_shared<HelpFormatter>();
 }

diff --git a/src/value.h b/src/value.h
@@ -213,7 +213,7 @@ class ConvertedValue : public Value
    }
 
    template<typename TVar>
-   void assignMissing( std::optional<std::vector<TVar>>& var, const std::string& value )
+   void assignMissing( std::optional<std::vector<TVar>>& var, const std::string& /*value*/ )
    {
       if ( !var.has_value() )
          var = std::vector<TVar>{};
@@ -228,7 +228,7 @@ class ConvertedValue : public Value
    }
 
    template<typename TVar>
-   void assignMissing( std::optional<TVar>& var, const std::string& value )
+   void assignMissing( std::optional<TVar>& var, const std::string& /*value*/ )
    {
       if ( !var.has_value() )
          var = TVar{};
@@ -249,7 +249,7 @@ class ConvertedValue : public Value
 
    template<typename TVar,
          std::enable_if_t<!has_from_string<TVar>::value && !can_convert<TVar>::value, int> = 0>
-   void assign( TVar& var, const std::string& value )
+   void assign( TVar&, const std::string& value )
    {
       Notifier::warn( "Assignment is not implemented. ('" + value + "')" );
    }

diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
@@ -31,6 +31,14 @@ add_executable( argumentumTests
    value_t.cpp
    )
 
+if( ARGUMENTUM_PEDANTIC )
+   target_compile_options( argumentumTests
+      PRIVATE
+      $<$<CXX_COMPILER_ID:GNU>:-Wall -Wextra -pedantic -Werror -Wl,--fatal-warnings>
+      $<$<CXX_COMPILER_ID:MSVC>:/W4 /WX /permissive- /Za>
+      )
+endif()
+
 target_link_libraries( argumentumTests
    ${GTEST_LIBRARIES}
    ${CMAKE_THREAD_LIBS_INIT}

diff --git a/test/action_t.cpp b/test/action_t.cpp
@@ -228,7 +228,7 @@ TEST( ArgumentParserActionTest, shouldReadOptionNameFromActionEvnironment )
 
 TEST( ArgumentParserActionTest, shouldReportErrorsThroughActionEvnironment )
 {
-   auto actionEnv = []( std::string& target, const std::string& value, Environment& env ) {
+   auto actionEnv = []( std::string& /*target*/, const std::string& /*value*/, Environment& env ) {
       env.add_error( "Something is wrong" );
    };
-Original file line number
+Diff line change
@@ Expand Up / @@ -4,6 +4,8 @@ build-*/ @@
     out/
     xdata/
+    CMakeSettings.json
     *.swp
     *.*~
     ~*.*
@@ Expand Down @@