Add SetTag endpoint

magefiles/generate/validations.go

@@ -25,8 +25,7 @@ var validations = map[string]string{
 	"LogMetric_Key":                      "required",
 	"LogMetric_Value":                    "required",
 	"LogMetric_Timestamp":                "required",
-	"SetTag_RunId":												"required",
-	"SetTag_Key":													"required",
-	"DeleteTag_RunId":										"required",
-	"DeleteTag_Key":											"required",
+	"SetTag_Key":                         "required",
+	"DeleteTag_RunId":                    "required",
+	"DeleteTag_Key":                      "required",
 }

pkg/tracking/service/tags.go

@@ -8,7 +8,13 @@ import (
 )
 
 func (ts TrackingService) SetTag(ctx context.Context, input *protos.SetTag) (*protos.SetTag_Response, *contract.Error) {
-	if err := ts.Store.SetTag(ctx, input.GetRunId(), input.GetKey(), input.GetValue()); err != nil {
+	runID := input.GetRunId()
+
+	if runID == "" {
+		runID = input.GetRunUuid()
+	}
+
+	if err := ts.Store.SetTag(ctx, runID, input.GetKey(), input.GetValue()); err != nil {
 		return nil, err
 	}
 

pkg/tracking/store/sql/tags.go

@@ -4,7 +4,6 @@ import (
 	"context"
 	"errors"
 	"fmt"
-	"strconv"
 
 	"gorm.io/gorm"
 	"gorm.io/gorm/clause"
@@ -92,14 +91,6 @@ func (s TrackingSQLStore) SetTag(
 		)
 	}
 
-	// If the runID can be parsed as a number, it should throw an error
-	if _, err := strconv.ParseFloat(runID, 64); err == nil {
-		return contract.NewError(
-			protos.ErrorCode_INVALID_PARAMETER_VALUE,
-			fmt.Sprintf("Invalid value %s for parameter 'run_id' supplied", runID),
-		)
-	}
-
 	err := s.db.WithContext(ctx).Transaction(func(transaction *gorm.DB) error {
 		contractError := checkRunIsActive(transaction, runID)
 		if contractError != nil {

pkg/validation/validation.go

@@ -107,6 +107,15 @@ func validateLogBatchLimits(structLevel validator.StructLevel) {
 	}
 }
 
+// SetTag must have either a run_id or a run_uuid present.
+func validateSetTagRunIDExists(structLevel validator.StructLevel) {
+	tag, isTag := structLevel.Current().Interface().(*protos.SetTag)
+
+	if isTag && tag.GetRunId() == "" && tag.GetRunUuid() == "" {
+		structLevel.ReportError(&tag, "run_id", "", "", "")
+	}
+}
+
 func truncateFn(fieldLevel validator.FieldLevel) bool {
 	param := fieldLevel.Param() // Get the parameter from the tag
 
@@ -188,6 +197,7 @@ func NewValidator() (*validator.Validate, error) {
 	}
 
 	validate.RegisterStructValidation(validateLogBatchLimits, &protos.LogBatch{})
+	validate.RegisterStructValidation(validateSetTagRunIDExists, &protos.SetTag{})
 
 	return validate, nil
 }