Skip to content

Commit

Permalink
Merge pull request #135 from mlexchange/fixJSConsoleErrors
Browse files Browse the repository at this point in the history 
small fixes for JS console errors
  • Loading branch information
@cleaaum
cleaaum authored Oct 4, 2023
2 parents 9cd7ff4 + 9d68053 commit 96df7d3
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 21 deletions.
3 changes: 1 addition & 2 deletions callbacks/control_bar.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ def edit_annotation_class(
class_color_identifier = {
"width": "25px",
"height": "25px",
"background-color": new_color + "50",
"backgroundColor": new_color + "50",
"margin": "5px",
"borderRadius": "3px",
"border": f"2px solid {new_color}",
Expand Down Expand Up @@ -640,7 +640,6 @@ def clear_annotation_class(
clientside_callback(
"""
function dash_filters_clientside(brightness, contrast) {
console.log(brightness, contrast)
js_path = "#image-viewer > div.js-plotly-plot > div > div > svg:nth-child(1)"
changeFilters(js_path, brightness, contrast)
return ""
Expand Down
20 changes: 10 additions & 10 deletions components/annotation_class.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def annotation_class_item(class_color, class_label, existing_ids, data=None):
style={
"width": "25px",
"height": "25px",
"background-color": class_color_transparent,
"backgroundColor": class_color_transparent,
"margin": "5px",
"borderRadius": "3px",
"border": f"2px solid {class_color}",
Expand All @@ -90,8 +90,8 @@ def annotation_class_item(class_color, class_label, existing_ids, data=None):
],
style={
"display": "flex",
"justify-content": "flex-row",
"align-items": "center",
"justifyContent": "flex-row",
"alignItems": "center",
"color": "#9EA4AB",
},
),
Expand All @@ -105,8 +105,8 @@ def annotation_class_item(class_color, class_label, existing_ids, data=None):
],
style={
"display": "flex",
"justify-content": "flex-row",
"align-items": "center",
"justifyContent": "flex-row",
"alignItems": "center",
"padding": "3px",
},
),
Expand Down Expand Up @@ -150,8 +150,8 @@ def annotation_class_item(class_color, class_label, existing_ids, data=None):
],
style={
"display": "flex",
"justify-content": "flex-row",
"align-items": "center",
"justifyContent": "flex-row",
"alignItems": "center",
},
),
html.Div(
Expand All @@ -166,7 +166,7 @@ def annotation_class_item(class_color, class_label, existing_ids, data=None):
],
style={
"display": "flex",
"justify-content": "flex-end",
"justifyContent": "flex-end",
},
),
],
Expand Down Expand Up @@ -202,7 +202,7 @@ def annotation_class_item(class_color, class_label, existing_ids, data=None):
],
style={
"display": "flex",
"justify-content": "flex-end",
"justifyContent": "flex-end",
},
),
],
Expand All @@ -228,7 +228,7 @@ def annotation_class_item(class_color, class_label, existing_ids, data=None):
],
style={
"display": "flex",
"justify-content": "flex-end",
"justifyContent": "flex-end",
},
),
],
Expand Down
14 changes: 7 additions & 7 deletions components/control_bar.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -297,10 +297,10 @@ def layout():
],
className="flex-row",
style={
"justify-content": "space-evenly",
"justifyContent": "space-evenly",
"padding": "2.5px",
"border": "1px solid #EAECEF",
"border-radius": "5px",
"borderRadius": "5px",
},
),
dmc.Space(w=10),
Expand Down Expand Up @@ -369,10 +369,10 @@ def layout():
className="flex-row",
style={
"width": "301px",
"justify-content": "space-evenly",
"justifyContent": "space-evenly",
"padding": "2.5px",
"border": "1px solid #EAECEF",
"border-radius": "5px",
"borderRadius": "5px",
},
),
]
Expand Down Expand Up @@ -464,8 +464,8 @@ def layout():
],
style={
"display": "flex",
"justify-content": "flex-row",
"align-items": "center",
"justifyContent": "flex-row",
"alignItems": "center",
},
),
html.Div(
Expand All @@ -477,7 +477,7 @@ def layout():
],
style={
"display": "flex",
"justify-content": "flex-end",
"justifyContent": "flex-end",
},
),
],
Expand Down
2 changes: 1 addition & 1 deletion components/image_viewer.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def layout():
"width": "100vw",
"height": "100vh",
"position": "fixed",
"z-index": 1,
"zIndex": 1,
},
),
],
Expand Down
2 changes: 1 addition & 1 deletion utils/plot_utils.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ def generate_notification_bg_icon_col(title, color, icon, message=""):
"icon": {
"height": "50px",
"width": "50px",
"background-color": f"{color} !important",
"backgroundColor": f"{color} !important",
}
},
)

0 comments on commit 96df7d3

Please sign in to comment.