Fix not_a_mod_or_admin errors
#131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sjmarf
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
LGTM 👍
We might want to consider upgrading to Swift 6 strict concurrency mode (#931) at some point. Having the project in that mode eliminates the possibility of data races occurring. Looks quite time consuming though. It might amount to just putting @MainActor everywhere lol.
Comment on lines
18
to
19
| } catch let ApiClientError.response(response, _) where response.error == "not_a_mod_or_admin" { | ||
| return .init(items: .init(), prevCursor: nil, nextCursor: nil) |
There was a problem hiding this comment.
In the ApiErrorResponse file we've got some precedent for how we match these errors. It would be better to continue that precedent here, I think.
In the longer-term it would be nice to create an enum of the error types. This looks possible to do in lemmy-swift-codegen - all of the error types are listed in LemmyErrorType.ts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend changes to address mlemgroup/mlem#1825. Does not require a Mlem PR, but this Mlem PR is pointed at this branch so the changes can be easily tested.
Report feed loaders and the report count in
UnreadCountnow catchnot_an_adminandnot_a_mod_or_adminerrors and return safe values.Thanks to the joy of multithreading, there are some race conditions that cause these functions to be called from the frontend which would be extremely painful to resolve; the frontend doesn't ever display the empty responses unless something goes seriously wrong, but the calls still get made and the errors still pop up.