-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for --outDir
option
#270
Conversation
57eaeb6
to
0256375
Compare
0256375
to
0c96314
Compare
Thanks for your contribution! I will review it at a later date. |
@apple-yagi Question: how does tsc or tsserver load For example, imagine the following project. repo: https://github.com/mizdra/hcm-output-folder-test
// package.json
{
"scripts": {
"dev:hcm": "hcm -o dist 'src/**/*.module.css'"
}
} // src/Button.tsx
import styles from from './Button.module.css';
export function Button() {
return <button class={styles.button}>Click me!</button>
} We need to tell tsc and tsserver that the type definition file for I believe I need to use To clarify my opinion: I am positive about implementing |
@mizdra Thank you for checking. I will resolve the issue by using the compilerOptions.rootDirs in tsconfig. By doing so, I can use the outputFolder without having to change paths and such. I've created a Pull Request, so please give it a try. |
Wow, this is a good solution. I am going to document the solution. Thank you! |
outputFolder
optionoutDir
option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for your great contribution! Sorry for the late review.
This feature is shipped in v3.2.0. https://github.com/mizdra/happy-css-modules/releases/tag/v3.2.0 |
I created a Pull Request because I wanted the outputFolder option available in
typed-css-modules
to also be present inhappy-css-modules
. Could you please review it?