Skip to content

Commit

Permalink
PHP8 (#5)
Browse files Browse the repository at this point in the history
* add php8 to test suite
* skip test on php 8 since function will now error out
  • Loading branch information
ins0 authored Nov 26, 2020
1 parent a724643 commit 410c3f9
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
php-versions: ['5.6', '7.4']
php-versions: ['5.6', '7.4', '8.0']
name: Testing PHP ${{ matrix.php-versions }}
steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"require": {
"ext-json": "*",
"guzzlehttp/psr7": "^1.6",
"php": "^5.6 || ^7.0",
"php": "^5.6 || ^7.0 || ^8.0",
"php-http/httplug": ">=1.1.0"
},
"suggest": {
Expand Down
5 changes: 4 additions & 1 deletion tests/VaultPHP/Exceptions/ExceptionsTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,10 @@ public function testSendRequestWillThrow() {
$client = new VaultClient($httpClient, $auth, TEST_VAULT_ENDPOINT);
$client->sendApiRequest('GET', '/foo', EndpointResponse::class);
}


/**
* @requires PHP <= 7.4
*/
public function testWillThrowWhenReturnClassDeclarationIsInvalid() {
$this->expectException(VaultException::class);
$this->expectExceptionMessage('Return Class declaration lacks static::fromResponse');
Expand Down

0 comments on commit 410c3f9

Please sign in to comment.