-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apps and Tools tab #117
Apps and Tools tab #117
Conversation
I forgot to sign the commits, but it's too late to muck around with git now so I'll take care of that tomorrow. |
The changes I made to the cards and things impacted the home page as well as the newly created apps and tools page. Make sure to check both out to validate correctness. Most changes made things align more with how the cms site was doing things, ex. hover color instead of elevation. |
I did my best to make sure that one could basically directly copy paste the above diff into the cms repo; however, that too will be a task for tomorrow. |
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
9ccd02d
to
92eb682
Compare
Signed-off-by: Amndeep Singh Mann <[email protected]>
Got it working with IE and fixed up the commits so that they're signed. Just need a review for the changes as discussed earlier.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the issue with IE anymore either. Looks good.
@aaronlippold I thought we were not moving forward with an apps/tools page atm so it's not a big deal if merge conflicts arise in this pr. |
Oh yeah I forgot we had that conversation. Let me double check with Eugene
and get back to you.
On Sat, Sep 19, 2020 at 1:19 PM Amndeep Singh Mann ***@***.***> wrote:
@aaronlippold <https://github.com/aaronlippold> I thought we were not
moving forward with an apps/tools page atm so it's not a big deal if merge
conflicts arise in this pr.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#117 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALK42CQHL6RI7MSBZGCB7TSGTR2XANCNFSM4QCWC4FQ>
.
--
--------
Aaron Lippold
[email protected]
260-255-4779
twitter/aim/yahoo,etc.
'aaronlippold'
|
CMSgov/saf#61