Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apps and Tools tab #117

Closed
wants to merge 5 commits into from
Closed

Apps and Tools tab #117

wants to merge 5 commits into from

Conversation

Amndeep7
Copy link

@Amndeep7 Amndeep7 self-assigned this Aug 18, 2020
@Amndeep7
Copy link
Author

I forgot to sign the commits, but it's too late to muck around with git now so I'll take care of that tomorrow.

@Amndeep7
Copy link
Author

The changes I made to the cards and things impacted the home page as well as the newly created apps and tools page. Make sure to check both out to validate correctness. Most changes made things align more with how the cms site was doing things, ex. hover color instead of elevation.

@Amndeep7
Copy link
Author

I did my best to make sure that one could basically directly copy paste the above diff into the cms repo; however, that too will be a task for tomorrow.

Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7
Copy link
Author

Amndeep7 commented Sep 8, 2020

Got it working with IE and fixed up the commits so that they're signed. Just need a review for the changes as discussed earlier.

The changes I made to the cards and things impacted the home page as well as the newly created apps and tools page. Make sure to check both out to validate correctness. Most changes made things align more with how the cms site was doing things, ex. hover color instead of elevation.

Copy link

@wdower wdower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the issue with IE anymore either. Looks good.

@aaronlippold
Copy link
Member

@wdower @Amndeep7 looks like one of the other PRs caused a merge conflict

@Amndeep7
Copy link
Author

@aaronlippold I thought we were not moving forward with an apps/tools page atm so it's not a big deal if merge conflicts arise in this pr.

@aaronlippold
Copy link
Member

aaronlippold commented Sep 19, 2020 via email

@Amndeep7 Amndeep7 closed this Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants