Refactor CLI #93
Merged
Refactor CLI #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a pretty substantial internal refactoring of the CLI implementation, but is purposefully designed not to break any backwards compatibility. A number of existing flags have been deprecated and removed from the CLI help text, but in fact are still present and work as they did before. This commit also introduces `hipcheck-macros`, a procedural macro helper crate for Hipcheck. Signed-off-by: Andrew Lilley Brinker <[email protected]>
This commit refactors the ready command to separate the different ready-checks from the result printing. The goal here is to give a better user experience with all results being reported together. Signed-off-by: Andrew Lilley Brinker <[email protected]>
|
This should hopefully fix the broken CLI test. It's also all been rebased on |
|
Haha looks like it broke some other tests. I'll have to debug it. |
Signed-off-by: Andrew Lilley Brinker <[email protected]>
This commit updates the tests for the CLI to use the new `CliConfig`
API. This also involves deprecation of the old `resolve_{cache, config,
data}` functions in the `session` module, as they're no longer doing
anything especially meaningful.
Signed-off-by: Andrew Lilley Brinker <[email protected]>
Signed-off-by: Andrew Lilley Brinker <[email protected]>
Signed-off-by: Andrew Lilley Brinker <[email protected]>
|
Realized that the existing tests actually no longer made sense with the CLI refactor. I've moved the key tests into the |
Signed-off-by: Andrew Lilley Brinker <[email protected]>
The `dirs` crate doesn't different config and data paths on MacOS and Windows, so we differentiate them ourselves to make sure we're not stuffing configuration and scripts into the same place. Signed-off-by: Andrew Lilley Brinker <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.