feat: implemented delete #818
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninaagrawal
force-pushed
the
ninaagrawal/plugins
branch
from
1bb3afb to
1d0407d
Compare
Signed-off-by: Nina 'Nino' Agrawal <[email protected]>
ninaagrawal
force-pushed
the
ninaagrawal/plugins
branch
from
1d0407d to
2d49a0e
Compare
|
Make sure to test, it should be safe to delete plugins since on a re-run they should be redownloaded, and if they're not that's a bug we don't want to ship to users. Also don't leave commented-out code in. If it's not used, delete it. If this PR is still a draft, make sure to mark it as a draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the delete function. Did not test implement actually deleting the files for safety