Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds hc ready command #81

Merged
merged 8 commits into from
May 30, 2024
Merged

feat: Adds hc ready command #81

merged 8 commits into from
May 30, 2024

Conversation

mchernicoff
Copy link
Contributor

Adds the hc ready command. This checks that:

  • git and NPM are installed and sufficiently up to date, and if installed prints their versions
  • The home directory, config file, and data directory can all be found, and if set prints their respective locations
  • The HC_GITHUB_TOKEN environment variable is set (but it does not check that the token is valid)

If git and NPM are up to date and home, config, and data are all found, the command reports that Hipcheck is ready to run. Otherwise it reports that Hipcheck is not ready.

@mchernicoff mchernicoff added the type: enhancement New feature or request label May 24, 2024
@mchernicoff mchernicoff added this to the 3.3.0 milestone May 24, 2024
@mchernicoff mchernicoff self-assigned this May 24, 2024
@mchernicoff
Copy link
Contributor Author

Draft PR because the PR with the CLI changes should be merged first, as this branch was forked from the branch for that PR. Once that PR is ready, rebase this branch and then merge.

@mchernicoff mchernicoff linked an issue May 24, 2024 that may be closed by this pull request
@mchernicoff
Copy link
Contributor Author

Tests are failing for the same reason as PR 79. See that PR for possible resolutions.

@alilleybrinker alilleybrinker marked this pull request as ready for review May 30, 2024 14:52
@alilleybrinker alilleybrinker force-pushed the mchernicoff/hc-doctor branch from ea5608f to 97b1467 Compare May 30, 2024 14:54
This is just to make it clear we're not committing to stability for it
yet.

Signed-off-by: Andrew Lilley Brinker <[email protected]>
@alilleybrinker alilleybrinker merged commit 8b69c42 into main May 30, 2024
6 of 9 checks passed
@alilleybrinker alilleybrinker deleted the mchernicoff/hc-doctor branch May 30, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add an hc doctor command that checks if Hipcheck is ready to run
2 participants