Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implemented list function for plugins #762

Merged
merged 1 commit into from
Jan 16, 2025
Merged

feat: implemented list function for plugins #762

merged 1 commit into from
Jan 16, 2025

Conversation

ninaagrawal
Copy link
Contributor

first implementation of the list function for plugins

@alilleybrinker alilleybrinker mentioned this pull request Jan 9, 2025
Closed
@ninaagrawal ninaagrawal force-pushed the ninaagrawal/plugins branch 3 times, most recently from f43c75c to 352cd4e Compare January 10, 2025 20:42
@ninaagrawal ninaagrawal requested review from patrickjcasey and j-lanson and removed request for patrickjcasey January 10, 2025 20:42
j-lanson
j-lanson requested changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@j-lanson j-lanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the thorough testing Nino. I'm requesting some changes for clarity and code hygiene, but overall it is looking good.

hipcheck/src/cache/plugin.rs Outdated Show resolved Hide resolved
hipcheck/src/cache/plugin.rs Outdated Show resolved Hide resolved
hipcheck/src/cache/plugin.rs Outdated Show resolved Hide resolved
hipcheck/src/cache/plugin.rs Outdated Show resolved Hide resolved
hipcheck/src/cache/plugin.rs Outdated Show resolved Hide resolved
hipcheck/src/cache/repo.rs Outdated Show resolved Hide resolved
@ninaagrawal ninaagrawal force-pushed the ninaagrawal/plugins branch 5 times, most recently from 350178d to b291a7b Compare January 15, 2025 21:21
@ninaagrawal ninaagrawal requested a review from j-lanson January 15, 2025 21:30
j-lanson
j-lanson requested changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@j-lanson j-lanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor things, otherwise its looking good to be merged

hipcheck/src/cache/plugin.rs Outdated Show resolved Hide resolved
hipcheck/src/cache/plugin.rs Outdated Show resolved Hide resolved
j-lanson
j-lanson approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@j-lanson j-lanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@j-lanson j-lanson force-pushed the ninaagrawal/plugins branch from 98d0032 to 56f734d Compare January 16, 2025 17:19
@j-lanson j-lanson merged commit 534fd14 into main Jan 16, 2025
10 checks passed
@alilleybrinker alilleybrinker deleted the ninaagrawal/plugins branch January 17, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-lanson j-lanson j-lanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Hipcheck Dev Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ninaagrawal @j-lanson