Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLRU added for git plugin #750

Merged
merged 1 commit into from
Jan 15, 2025
Merged

CLRU added for git plugin #750

merged 1 commit into from
Jan 15, 2025

Conversation

aamohd
Copy link
Contributor

@aamohd aamohd commented Dec 30, 2024

12/30 - The PR has changes to the git plugin that uses an LRU cache functionality. The configurability of the size of the cache would come after the #662 changes are pulled.

@aamohd aamohd requested a review from j-lanson December 30, 2024 20:49
j-lanson
j-lanson requested changes Jan 3, 2025
View reviewed changes
plugins/git/src/git.rs Outdated Show resolved Hide resolved
plugins/git/src/git.rs Outdated Show resolved Hide resolved
@aamohd aamohd force-pushed the aamohd/git-cache-config branch from 1ca88e2 to ecaf313 Compare January 10, 2025 20:32
@aamohd aamohd requested a review from j-lanson January 10, 2025 20:34
j-lanson
j-lanson reviewed Jan 13, 2025
View reviewed changes
plugins/git/src/git.rs Outdated Show resolved Hide resolved
j-lanson
j-lanson reviewed Jan 13, 2025
View reviewed changes
plugins/git/src/git.rs Outdated Show resolved Hide resolved
j-lanson
j-lanson requested changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@j-lanson j-lanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few logic changes to make the code cleaner. Also, you'll need to rebase off main and address the git/Cargo.toml merge conflict.

plugins/git/src/main.rs Outdated Show resolved Hide resolved
plugins/git/src/main.rs Outdated Show resolved Hide resolved
site/content/docs/guide/plugins/mitre-git.md Outdated Show resolved Hide resolved
@aamohd aamohd requested a review from j-lanson January 14, 2025 20:05
@aamohd aamohd force-pushed the aamohd/git-cache-config branch 2 times, most recently from 7b24862 to 2369ebb Compare January 15, 2025 16:49
@aamohd aamohd marked this pull request as ready for review January 15, 2025 17:00
j-lanson
j-lanson requested changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@j-lanson j-lanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just change the commit message to feat: configurable commit cache size in git plugin

@aamohd aamohd force-pushed the aamohd/git-cache-config branch from 2369ebb to ff24dfa Compare January 15, 2025 18:11
@aamohd aamohd requested a review from j-lanson January 15, 2025 18:20
@j-lanson j-lanson merged commit f6e250c into main Jan 15, 2025
11 checks passed
@j-lanson j-lanson mentioned this pull request Jan 15, 2025
Closed
@alilleybrinker alilleybrinker deleted the aamohd/git-cache-config branch January 17, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-lanson j-lanson j-lanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Hipcheck Dev Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aamohd @j-lanson