feat(refactor): initial RFD5 impl, slight refspec handling improvement #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-lanson
added
type: enhancement
Signed-off-by: jlanson <[email protected]>
j-lanson
force-pushed
the
jlanson/rfd5
branch
from
0d77ccc to
04c1e0f
Compare
mchernicoff
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #743 .
This PR simply refactors the existing logic for target resolution into the form proposed by RFD5. In a subsequent PR I will add fuzzy version checking for packages and code for getting the newest version of an npm package by parsing the JSON object.
There are slight improvements to the selection of what git ref to target based on what seed we resolved from in
get_checkout_target().