Refactor utility modules #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the top-level test_util.rs file under the `util/` module, and updates callers to use the new path. Signed-off-by: Andrew Lilley Brinker <[email protected]>
"Redacted" seems like a clearer name than "Hidden." This also updates the struct name and callers. Signed-off-by: Andrew Lilley Brinker <[email protected]>
This commit moves the 'http' module under the 'util' module, and updates callers. Signed-off-by: Andrew Lilley Brinker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes multiple refactors of utility modules to move some things out of the top-level, improve naming slightly, and generally make the Hipcheck codebase easier to navigate.