Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate policy expressions code #265

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

alilleybrinker
Copy link
Collaborator

@alilleybrinker alilleybrinker commented Aug 8, 2024

This is still a work-in-progress, and nothing is actually used yet, but this at least moves over the draft implementation of policy expressions from the external experimental repo I'd made to enable integration with Hipcheck.

The other thing I did was organize the Cargo.toml file for the hipcheck crate, particularly to put all dependencies in alphabetical order, as they had been at one point previously.

Resolves #260

@alilleybrinker alilleybrinker added the type: chore Clean up or management task. label Aug 8, 2024
@alilleybrinker alilleybrinker added this to the 3.6.0 milestone Aug 8, 2024
@alilleybrinker alilleybrinker requested a review from a team August 8, 2024 18:28
@alilleybrinker alilleybrinker self-assigned this Aug 8, 2024
@alilleybrinker alilleybrinker requested review from patrickjcasey and removed request for a team August 8, 2024 18:28
@alilleybrinker alilleybrinker force-pushed the alilleybrinker/policy-expr branch from 05af67e to 6383360 Compare August 8, 2024 18:40
@alilleybrinker alilleybrinker changed the title chore: Integrated policy expressions code Integrate policy expressions code Aug 8, 2024
@alilleybrinker
Copy link
Collaborator Author

Looks like I'll need to rebase to get this working.

@alilleybrinker alilleybrinker force-pushed the alilleybrinker/policy-expr branch from 6383360 to d1680f5 Compare August 13, 2024 16:08
This is still a work-in-progress, and nothing is actually used
yet, but this at least moves over the draft implementation of policy
expressions from the external experimental repo I'd made to enable
integration with Hipcheck.

The other thing I did was organize the Cargo.toml file for the hipcheck
crate, particularly to put all dependencies in alphabetical order, as
they had been at one point previously.

Signed-off-by: Andrew Lilley Brinker <[email protected]>
@alilleybrinker alilleybrinker force-pushed the alilleybrinker/policy-expr branch from d1680f5 to 0a6f267 Compare August 23, 2024 18:02
Copy link
Collaborator

@j-lanson j-lanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mchernicoff mchernicoff merged commit bbdd162 into main Aug 23, 2024
9 checks passed
@alilleybrinker alilleybrinker deleted the alilleybrinker/policy-expr branch August 29, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Clean up or management task.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Bring policy expression implementation into Hipcheck repo
3 participants