Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Slightly modified arguments for hc setup. #155

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

alilleybrinker
Copy link
Collaborator

This is intended to make it a little bit clearer to use, specifically by converting the positional argument into a flag, and by adding more explanatory text.

This is intended to make it a little bit clearer to use, specifically by
converting the positional argument into a flag, and by adding more
explanatory text.

Signed-off-by: Andrew Lilley Brinker <[email protected]>
@alilleybrinker alilleybrinker added type: enhancement New feature or request type: ui UI-related changes that should get heightened review. labels Jun 26, 2024
@alilleybrinker alilleybrinker added this to the 3.4.0 milestone Jun 26, 2024
@alilleybrinker alilleybrinker self-assigned this Jun 26, 2024
hipcheck/src/cli.rs Outdated Show resolved Hide resolved
Signed-off-by: Andrew Lilley Brinker <[email protected]>
Copy link
Collaborator

@j-lanson j-lanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@alilleybrinker alilleybrinker merged commit d21e14e into main Jun 27, 2024
9 checks passed
@alilleybrinker alilleybrinker deleted the alilleybrinker/setup-ui branch July 4, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request type: ui UI-related changes that should get heightened review.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants