chore: refactor affiliation analysis, experiment with macro #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(new copy of PR #132 rebased off of main)
Continuation of effort on #28.
This adds affiliation to the set of analyses using the new scoring/storage system, but the main contribution of this PR is the run_and_score_threshold_analysis macro defined in score.rs. If approved, this will make converting the rest of the analyses much simpler and reduce lines of (committed) code. The macro is a bit in-elegant but we expect churn in this area of Hipcheck in the next few months anyway, I doubt this will remain for very long.
It might also be worthwhile to add a similar macro for analyses on the new system in analysis/report_builder.rs.