Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress console logs #6579

Merged
merged 7 commits into from
Jan 29, 2025
Merged

Cypress console logs #6579

merged 7 commits into from
Jan 29, 2025

Conversation

Amndeep7
Copy link
Contributor

No description provided.

…output logs. currently configured to only do so on failing tests

Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7
Copy link
Contributor Author

image

https://github.com/mitre/heimdall2/actions/runs/13025550260/job/36333906688?pr=6579

Passing run but note how we can look at the logs of the test that eventually decided to pass after repeated attempts. You can see that the problem was just with the request to the splunk server blowing up for no reason and returning a 401 as opposed to ex. you breaking the app.

Does this mean that we should probably fix up the splunk<->heimdall code so that it's less likely to 401? Yes. But at least now we can more confidently review the e2e cypress test logs and say "flakey" and move on as opposed to being worried.

@Amndeep7 Amndeep7 requested a review from em-c-rod January 29, 2025 06:29
@Amndeep7 Amndeep7 merged commit 0b6b85c into master Jan 29, 2025
18 checks passed
@Amndeep7 Amndeep7 deleted the cypress_console_logs branch January 29, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants