WIP: add a leaf map #63
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When proving, we currently ask for positions. However, positions may change during updates, so externally holding those positions may be cumbersome. The leaf hash, on the other hand never changes. This commit does the same we do for `MemForest`, creating a map from leaf hashes to a reference to the actual leaf in memory. Once we need to prove it, we compute the position on-the-fly.
This commit makes all proving-related methods take leaf hashes instead of positions, and adds additional tests to proving and ingesting proofs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When proving, we currently ask for positions. However, positions may change during updates, so externally holding those positions may be cumbersome. The leaf hash, on the other hand never changes.
This commit does the same we do for
MemForest, creating a map from leaf hashes to a reference to the actual leaf in memory. Once we need to prove it, we compute the position on-the-fly.