Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): デッキのプロファイルが新規作成できない問題を修正 #15406

Merged

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Feb 5, 2025

What

  • プロファイルのIDの切り替えはなされるものの、レイアウト自体がレジストリに書き込まれていなかったのを修正
    ↑ページが読み込まれてから一度もデッキのレイアウトを操作していないとsaveDeckが一度も発動せず保存できない減少が起こる
  • 書き込み処理を待ってから再読み込みを行うように

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Feb 5, 2025
@kakkokari-gtyih kakkokari-gtyih added this to the v2025.2.0 milestone Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 18.83%. Comparing base (fbc6d0d) to head (0ba1e28).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/ui/deck.vue 0.00% 20 Missing ⚠️
packages/frontend/src/ui/deck/deck-store.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15406       +/-   ##
============================================
- Coverage    38.70%   18.83%   -19.88%     
============================================
  Files         1603      764      -839     
  Lines       204293   111053    -93240     
  Branches      4013     1232     -2781     
============================================
- Hits         79074    20913    -58161     
+ Misses      124581    89553    -35028     
+ Partials       638      587       -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih changed the title fix(frontend): デッキのプロファイルが保存できない問題を修正 fix(frontend): デッキのプロファイルが新規作成できない問題を修正 Feb 5, 2025
@mi-gh-maintainer mi-gh-maintainer bot merged commit fd88066 into misskey-dev:develop Feb 5, 2025
22 checks passed
Copy link

Thank you 🙏

@kakkokari-gtyih kakkokari-gtyih deleted the fix-deck-profile-save branch February 5, 2025 08:19
DA-TENSHI pushed a commit to SHINANOSKEY-Projekt/SHINANOSKEY that referenced this pull request Feb 5, 2025
* fix(frontend): デッキのプロファイルが保存できない問題を修正

* Update Changelog

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

1 participant