Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): スラッシュを含むページを閲覧できるように #15394

Merged
merged 4 commits into from
Feb 4, 2025

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Feb 4, 2025

What

代わりに「ソースを見る」機能を廃止した
view-source/view-source というページURLが来たときにソースを見るためのページが出る問題を回避できない かつ ソースを見る機能は動的ページの名残なので、もはや在っても見ることが少ないかも?)

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Feb 4, 2025
@syuilo
Copy link
Member

syuilo commented Feb 4, 2025

ちなみにスラッシュなどの記号を使えなくする修正は今実装中

@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Feb 4, 2025

ちなみにスラッシュなどの記号を使えなくする修正は今実装中

それならもうやってたはず(色々まとめて作業中(メンテナアクセスのためにおいてあったPR)のやつの中に含んでいた)

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 18.83%. Comparing base (495d72e) to head (a511bd4).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/pages/page.vue 0.00% 1 Missing ⚠️
packages/frontend/src/router/definition.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15394       +/-   ##
============================================
- Coverage    38.70%   18.83%   -19.87%     
============================================
  Files         1603      764      -839     
  Lines       204309   111045    -93264     
  Branches      4011     1232     -2779     
============================================
- Hits         79068    20913    -58155     
+ Misses      124603    89545    -35058     
+ Partials       638      587       -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih deleted the fix-12558 branch February 4, 2025 07:44
@syuilo
Copy link
Member

syuilo commented Feb 4, 2025

closeされたのは何でかしら

@kakkokari-gtyih
Copy link
Contributor Author

closeされたのは何でかしら

スラッシュを含むページURLが許容できなくなるなら、スラッシュありを考慮した仕様にする必要が無さそうなので(どちらかだけで良い?)

@syuilo
Copy link
Member

syuilo commented Feb 4, 2025

今後許容されなくなっても今まで作られたものはそのままになる(マイグレ用意しない限り)

@syuilo
Copy link
Member

syuilo commented Feb 4, 2025

マージするぞ

@kakkokari-gtyih kakkokari-gtyih restored the fix-12558 branch February 4, 2025 08:29
@kakkokari-gtyih kakkokari-gtyih added this to the v2025.2.0 milestone Feb 4, 2025
@mi-gh-maintainer mi-gh-maintainer bot merged commit cb48853 into misskey-dev:develop Feb 4, 2025
43 checks passed
Copy link

Thank you 🙏

@kakkokari-gtyih kakkokari-gtyih deleted the fix-12558 branch February 4, 2025 08:44
DA-TENSHI pushed a commit to SHINANOSKEY-Projekt/SHINANOSKEY that referenced this pull request Feb 5, 2025
* fix(frontend): スラッシュを含むページを閲覧できるように

* Update Changelog

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

2 participants