Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): MkSparkleが動作しない問題を修正 #15390

Merged
merged 6 commits into from
Feb 4, 2025
Merged

fix(frontend): MkSparkleが動作しない問題を修正 #15390

merged 6 commits into from
Feb 4, 2025
+31 −23

Conversation

kakkokari-gtyih
Copy link
Contributor

What

animateTransformではなく、CSSでアニメーションさせるようにしたら動いた

Why

Fix #14155

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Feb 4, 2025
@syuilo
Copy link
Member

syuilo commented Feb 4, 2025

animateTransformが使えない理由を残しておくとよさそう

@kakkokari-gtyih
Copy link
Contributor Author

animateTransformが使えない理由を残しておくとよさそう

結局なんでかはわからなかったのよね

@syuilo
Copy link
Member

syuilo commented Feb 4, 2025

「Chromeにおいて上手く表示されない」じゃダメかしら

@codecov Codecov
Copy link

codecov bot commented Feb 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.68%. Comparing base (1985763) to head (272879c).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff              @@
##           develop   #15390       +/-   ##
============================================
- Coverage    38.62%   18.68%   -19.94%     
============================================
  Files         1603      764      -839     
  Lines       204302   111052    -93250     
  Branches      4016     1234     -2782     
============================================
- Hits         78903    20749    -58154     
+ Misses      124791    89714    -35077     
+ Partials       608      589       -19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor Author

「Chromeにおいて上手く表示されない」じゃダメかしら

そうした

@mi-gh-maintainer mi-gh-maintainer bot merged commit 495d72e into misskey-dev:develop Feb 4, 2025
22 checks passed
@mi-gh-maintainer mi-gh-maintainer
Copy link

Thank you 🙏

@kakkokari-gtyih kakkokari-gtyih deleted the fix-14155 branch February 4, 2025 05:04
DA-TENSHI pushed a commit to SHINANOSKEY-Projekt/SHINANOSKEY that referenced this pull request Feb 5, 2025
@kakkokari-gtyih @DA-TENSHI
fix(frontend): MkSparkleが動作しない問題を修正 (misskey-dev#15390)
21f1a81 
* fix(frontend): MkSparkleが動作しない問題を修正

* Update Changelog

* fix

* add comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
packages/frontend Client side specific issue/PR
Projects
[実験中] 管理用
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chromeにおいて$[sparkle xxx]のエフェクトが上手く表示されない
2 participants
@kakkokari-gtyih @syuilo