Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): definePropsを別途インポートしている箇所を除去 #15375

Conversation

kakkokari-gtyih
Copy link
Contributor

What

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@kakkokari-gtyih kakkokari-gtyih added this to the v2025.2.0 milestone Feb 1, 2025
@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Feb 1, 2025
Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 18.77%. Comparing base (a3d236c) to head (a25430d).
Report is 565 commits behind head on develop.

Files with missing lines Patch % Lines
...ges/frontend/src/components/MkRoleSelectDialog.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15375       +/-   ##
============================================
- Coverage    41.74%   18.77%   -22.98%     
============================================
  Files         1549      764      -785     
  Lines       196555   111027    -85528     
  Branches      2767     1234     -1533     
============================================
- Hits         82055    20843    -61212     
+ Misses      113939    89596    -24343     
- Partials       561      588       +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mi-gh-maintainer mi-gh-maintainer bot merged commit ae65aec into misskey-dev:develop Feb 1, 2025
22 checks passed
Copy link

Thank you 🙏

@kakkokari-gtyih kakkokari-gtyih deleted the refactor-remove-unnecessary-imports branch February 1, 2025 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

1 participant