Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): MkDriveFileThumbnail / MkNoteMediaGridの修正 #15365

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Jan 30, 2025

What

  • MkDriveFileThumbnailのpropsのタイポ修正
  • MkNoteMediaGridをデータセーバーに対応させた

Why

ユーザー名の「ファイル」タブで、センシティブ画像が読み込まれてしまう・データセーバー有効時にも画像が読み込まれてしまう問題(ただしセンシティブの方に関しては別途オーバーレイでのぼかしも入っているため実際に見えるわけではない)を修正するため

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jan 30, 2025
@kakkokari-gtyih kakkokari-gtyih marked this pull request as draft January 30, 2025 06:22
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.

Project coverage is 18.77%. Comparing base (a3d236c) to head (b8d4b46).
Report is 560 commits behind head on develop.

Files with missing lines Patch % Lines
...ckages/frontend/src/components/MkNoteMediaGrid.vue 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15365       +/-   ##
============================================
- Coverage    41.74%   18.77%   -22.98%     
============================================
  Files         1549      764      -785     
  Lines       196555   111037    -85518     
  Branches      2767     1234     -1533     
============================================
- Hits         82055    20843    -61212     
+ Misses      113939    89606    -24333     
- Partials       561      588       +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih changed the title fix(frontend): MkDriveFileThumbnailのpropsのタイポ修正 fix(frontend): MkDriveFileThumbnail / MkNoteMediaGridの修正 Jan 30, 2025
@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review January 30, 2025 06:37
@kakkokari-gtyih kakkokari-gtyih added this to the v2025.2.0 milestone Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

1 participant