Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ドライブのデフォルト以外のソートでページネーションが正しくない ( #15270 ) #15356

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tetsuya-ki
Copy link
Contributor

  • -createdAtのfetchMoreFilesDataを修正
  • ソートから+size,-size,+name,-nameの削除

What

  • ドライブ画面のソートからサイズ(昇順),サイズ(降順),名前(昇順),名前(降順)の削除
    • パフォーマンス懸念があるため、削除しました
  • ドライブ画面のファイル読み込みを修正

Why

  • ドライブでデフォルト以外のソートを選んだ時、ファイルが全部見れなくて困ってしまうため

Additional info (optional)

  • 画像

image

  • (ソート欲しい人向け追加情報)小規模サーバーの場合は以下で問題ない気もするので、ソートが欲しい人がいたら↓をつかってもいいかもです

#15278

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

- -createdAtのfetchMoreFilesDataを修正
-  ソートから+size,-size,+name,-nameの削除
@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 18.82%. Comparing base (9230ee5) to head (c1ad345).

Files with missing lines Patch % Lines
packages/frontend/src/components/MkDrive.vue 0.00% 20 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15356       +/-   ##
============================================
- Coverage    38.68%   18.82%   -19.86%     
============================================
  Files         1603      764      -839     
  Lines       204302   111042    -93260     
  Branches      4042     1233     -2809     
============================================
- Hits         79040    20907    -58133     
+ Misses      124622    89548    -35074     
+ Partials       640      587       -53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tetsuya-ki tetsuya-ki changed the title fix #15270 fix: ドライブのデフォルト以外のソートでページネーションが正しくない ( #15270 ) Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

1 participant