Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): デフォルト起動時のメインプロセスはHTTPサーバモジュールのみ読み込む #15355

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

samunohito
Copy link
Member

@samunohito samunohito commented Jan 27, 2025

What

①のうち、以下をすべて満たす場合の処理を、②の同条件の処理と同等にします。

  • envOption.disableClustering === false
  • envOption.onlyQueue === false
  • envOption.onlyServer === false

①このまえ変更した実装
https://github.com/misskey-dev/misskey/blob/8ad97e5e/packages/backend/src/boot/master.ts#L98-L124

②旧来の実装
https://github.com/misskey-dev/misskey/blob/65d19279/packages/backend/src/boot/master.ts#L94-L113

Why

元々の動きと合わせるため
#15279 (comment)

Additional info (optional)

  • メインプロセスではHTTPサーバモジュールのみが読み込まれること
  • ワーカープロセスでジョブキューモジュールが読み込まれること

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@samunohito samunohito requested a review from syuilo January 27, 2025 12:34
@samunohito samunohito marked this pull request as ready for review January 27, 2025 12:34
@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jan 27, 2025
@samunohito samunohito mentioned this pull request Jan 27, 2025
Copy link
Contributor

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 38.70%. Comparing base (0a41e36) to head (2158eb4).
Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/boot/master.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15355      +/-   ##
===========================================
- Coverage    38.77%   38.70%   -0.08%     
===========================================
  Files         1601     1603       +2     
  Lines       203902   204283     +381     
  Branches      4011     4014       +3     
===========================================
+ Hits         79065    79069       +4     
- Misses      124201   124608     +407     
+ Partials       636      606      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mi-gh-maintainer mi-gh-maintainer bot merged commit 8232ea6 into misskey-dev:develop Jan 27, 2025
31 of 33 checks passed
Copy link

Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

1 participant