Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Embedded all attachment, renotes and discussion history into rss feed content & improve title (2025) #15353

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

CGsama
Copy link
Contributor

@CGsama CGsama commented Jan 26, 2025

What

The feed npm module dose not support multiple files, and enclosure format may not parse correct by apps, so that embedding all files into content. Also the email field is required by some app, so add a dummy one, could improved by use user email if have one.
The feed also can track back x posts for reply and renote, will include 10 most recent notes in the thread

Why

#7004

Additional info (optional)

Change originally made for #6696 at v11 and #8834 for v12, now for latest to match file structure, working fine on my instance (v11/v12/firefish) for years

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jan 26, 2025
Copy link
Contributor

github-actions bot commented Jan 26, 2025

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 5.30973% with 107 lines in your changes missing coverage. Please review.

Project coverage is 37.68%. Comparing base (297186e) to head (0636de6).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/server/web/FeedService.ts 5.30% 107 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15353      +/-   ##
===========================================
- Coverage    38.70%   37.68%   -1.03%     
===========================================
  Files         1603     1603              
  Lines       204267   204369     +102     
  Branches      4015     3711     -304     
===========================================
- Hits         79067    77012    -2055     
- Misses      124594   126751    +2157     
  Partials       606      606              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CGsama CGsama marked this pull request as ready for review January 26, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

1 participant