-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: MkInputをジェネリックコンポーネントにする #15345
base: develop
Are you sure you want to change the base?
fix: MkInputをジェネリックコンポーネントにする #15345
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15345 +/- ##
============================================
- Coverage 38.70% 19.86% -18.85%
============================================
Files 1603 764 -839
Lines 204267 111030 -93237
Branches 4015 1302 -2713
============================================
- Hits 79067 22053 -57014
+ Misses 124594 88395 -36199
+ Partials 606 582 -24 ☔ View full report in Codecov by Sentry. |
MkInputのtype属性に関してはwithDefaultsを使ってむしろデフォルトvalueをtextにしてしまう手もあると思うのですがどうでしょうか…?(現在と変わらない使い勝手で型エラーを減らせるはず、かつ同時並行で動いているPRが死なないと思うのですが) |
|
What
MkInput
をジェネリックコンポーネントにしてupdate:modelValue
イベントの値の型がtype
プロパティに合うように変更MkInput
を使用してる箇所で省略されていたtype="text"
を追加して型エラーを低減Why
#15173 (comment) 関連
Additional info (optional)
Checklist