Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): verbatimModuleSyntaxを有効化 #15323

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Jan 21, 2025

What

frontend, frontend-shared, frontend-embedでverbatimModuleSyntaxを有効化

import { someVar, SomeType } from '@/somewhere.js';

// TSコンパイラ的にはOKだが、統一のためこれはLintにより禁止
import { someVar, type SomeType } from '@/somewhere.js';

// これが正解
import { someVar } from '@/somewhere.js';
import type { SomeType } from '@/somewhere.js';

になる

Why

Fix #14113

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 17.70073% with 451 lines in your changes missing coverage. Please review.

Project coverage is 18.87%. Comparing base (31ccefa) to head (221d6e2).

Files with missing lines Patch % Lines
...ckages/frontend/src/components/MkNoteMediaGrid.vue 0.00% 29 Missing ⚠️
packages/frontend/src/components/grid/MkGrid.vue 0.00% 11 Missing ⚠️
...ackages/frontend/src/components/grid/grid-utils.ts 0.00% 8 Missing ⚠️
...ges/admin/custom-emojis-manager.local.register.vue 0.00% 7 Missing ⚠️
...ackages/frontend/src/widgets/WidgetAiscriptApp.vue 0.00% 7 Missing ⚠️
packages/frontend/src/components/grid/cell.ts 0.00% 6 Missing ⚠️
packages/frontend/src/components/grid/column.ts 0.00% 6 Missing ⚠️
...d/src/pages/admin/custom-emojis-manager.remote.vue 0.00% 6 Missing ⚠️
packages/frontend/src/pages/flash/flash.vue 0.00% 6 Missing ⚠️
packages/frontend/src/pages/scratchpad.vue 0.00% 6 Missing ⚠️
... and 185 more
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15323       +/-   ##
============================================
- Coverage    38.77%   18.87%   -19.91%     
============================================
  Files         1601      764      -837     
  Lines       203899   110930    -92969     
  Branches      3860     1233     -2627     
============================================
- Hits         79065    20937    -58128     
+ Misses      124198    89406    -34792     
+ Partials       636      587       -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review January 21, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

refactor: verbatimModuleSyntax を導入する
1 participant