fix: iPadでdeck uiでマウスホイールでスクロールできない #15244
Open
+16
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatawa12
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15244 +/- ##
============================================
- Coverage 39.40% 18.82% -20.59%
============================================
Files 1607 764 -843
Lines 210127 111056 -99071
Branches 3785 1233 -2552
============================================
- Hits 82803 20907 -61896
+ Misses 126718 89562 -37156
+ Partials 606 587 -19 ☔ View full report in Codecov by Sentry. |
anatawa12
added a commit
to anatawa12/misskey
that referenced
this pull request
Jan 28, 2025
commit b299046 Author: anatawa12 <[email protected]> Date: Thu Jan 9 20:23:25 2025 +0900 docs(changelog): iPadOSでdeck uiをマウスカーソルによってスクロールできない問題を修正 commit 8a531b7 Author: anatawa12 <[email protected]> Date: Thu Jan 9 20:11:34 2025 +0900 fix: ipadでdeck uiでスクロールできない
5 tasks
syuilo
reviewed
Feb 3, 2025
packages/frontend/src/ui/deck.vue
Outdated
| } | ||
|
|
||
| document.addEventListener('pointerdown', pointerEvent); | ||
| document.addEventListener('pointermove', pointerEvent); |
There was a problem hiding this comment.
pointerDown / upだけでいい説はありますね。ちょっと試してみます。
There was a problem hiding this comment.
pointerdownだけで実装できました https://github.com/misskey-dev/misskey/pull/15244/files#r1938865257
anatawa12
commented
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
iPadOSでマウスホイールを使用してスクロールができない問題を修正しました。
また、水平スクロールができない問題の修正のため、マウスホイールでスクロールしてるときには snap を無効化するようにしました。
Fix #11733
Relates #7220?
Why
Additional info (optional)
Checklist