Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): デッキでダブルクリックするとウィンドウが2枚開く問題を修正 #15105

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Dec 9, 2024

What

router遷移時に最初のクリックから300msは操作を抑止するようにした
dblclickclickの併用は無理みたい)

Why

Fix #14810

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 18.81%. Comparing base (607bf60) to head (66858cb).

Files with missing lines Patch % Lines
packages/frontend/src/ui/deck.vue 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15105      +/-   ##
===========================================
- Coverage    18.82%   18.81%   -0.01%     
===========================================
  Files          766      766              
  Lines       111400   111408       +8     
  Branches      1234     1234              
===========================================
  Hits         20966    20966              
- Misses       89845    89853       +8     
  Partials       589      589              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@syuilo
Copy link
Member

syuilo commented Jan 8, 2025

デッキ以外では発生しないのかしら

@syuilo
Copy link
Member

syuilo commented Jan 8, 2025

あと2回クリックしているのであれば2回分の動作が行われるのはそんんなに不自然ではないわね(便利というわけでもないけど)

@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Jan 8, 2025

デッキ以外では発生しないのかしら

発生しているはずだけど、通常UIでは同一ルート→同一ルートの遷移なので見かけ上何も起こらないのに対してデッキの場合は強制的にウィンドウで開くので2枚表示されてしまう

@syuilo
Copy link
Member

syuilo commented Jan 8, 2025

あーナビゲーション設定変更できるのはデッキだけか

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih kakkokari-gtyih added this to the v2025.2.1 milestone Feb 1, 2025
@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

ダブルクリックでウィンドウが2個起動しないようにする
2 participants