Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): 画面を閉じる直前にAudioContextを閉じるように #15080

Conversation

kakkokari-gtyih
Copy link
Contributor

What

書いてあるとおり

Why

Chrome 系 on macOS で AudioContext 開きっぱなしの状態でタブ閉じると他のタブのオーディオが壊れる問題にぶち当たる(らしい)

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 1, 2024
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 18.87%. Comparing base (ef29130) to head (5ba5d13).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/scripts/sound.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15080       +/-   ##
============================================
- Coverage    37.74%   18.87%   -18.88%     
============================================
  Files         1601      762      -839     
  Lines       204016   110763    -93253     
  Branches      3713     1231     -2482     
============================================
- Hits         77014    20903    -56111     
+ Misses      126364    89275    -37089     
+ Partials       638      585       -53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo
Copy link
Member

syuilo commented Dec 10, 2024

chromeのバグということを明記した方が良さそう

@mi-gh-maintainer mi-gh-maintainer bot merged commit 791b450 into misskey-dev:develop Jan 26, 2025
8 of 9 checks passed
Copy link

Thank you 🙏

@kakkokari-gtyih kakkokari-gtyih deleted the fix-close-audiocontext-before-unload branch January 26, 2025 06:50
Ruruke pushed a commit to Ruruke/rukey that referenced this pull request Jan 26, 2025
* fix(frontend): 画面を閉じる直前にAudioContextを閉じるように

* Update Changelog

* Update CHANGELOG.md

---------

Co-authored-by: syuilo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

2 participants