-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(frontend): 画面を閉じる直前にAudioContextを閉じるように #15080
Merged
mi-gh-maintainer
merged 7 commits into
misskey-dev:develop
from
kakkokari-gtyih:fix-close-audiocontext-before-unload
Jan 26, 2025
Merged
fix(frontend): 画面を閉じる直前にAudioContextを閉じるように #15080
mi-gh-maintainer
merged 7 commits into
misskey-dev:develop
from
kakkokari-gtyih:fix-close-audiocontext-before-unload
Jan 26, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15080 +/- ##
============================================
- Coverage 37.74% 18.87% -18.88%
============================================
Files 1601 762 -839
Lines 204016 110763 -93253
Branches 3713 1231 -2482
============================================
- Hits 77014 20903 -56111
+ Misses 126364 89275 -37089
+ Partials 638 585 -53 ☔ View full report in Codecov by Sentry. |
chromeのバグということを明記した方が良さそう |
mi-gh-maintainer
bot
merged commit Jan 26, 2025
791b450
into
misskey-dev:develop
8 of 9 checks passed
Thank you 🙏 |
Ruruke
pushed a commit
to Ruruke/rukey
that referenced
this pull request
Jan 26, 2025
* fix(frontend): 画面を閉じる直前にAudioContextを閉じるように * Update Changelog * Update CHANGELOG.md --------- Co-authored-by: syuilo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
書いてあるとおり
Why
Chrome 系 on macOS で AudioContext 開きっぱなしの状態でタブ閉じると他のタブのオーディオが壊れる問題にぶち当たる(らしい)
Additional info (optional)
Checklist