Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 特定ロールポリシーによる運営アクティビティの検知範囲拡大に対応 #14974

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

samunohito
Copy link
Member

What

運営アクティビティの検知範囲は「rootユーザであること」「モデレータ以上の権限を有するロールにアサインされていること」に限られていましたが、非モデレータロールでも特定のポリシーを有するロールにアサインされていればアクティビティの検知対象とするようにしました。
デフォルト値はfalseなので、明示的に有効化しない限りは機能しません。

Why

#13437 の対応

Additional info (optional)

  • UnitTestを作成して確認
  • 対象ポリシーを持つ非モデレータロールを用意し、実際にジョブを動かして招待制に切り替わることを確認

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/misskey-js packages/backend:test labels Nov 16, 2024
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 72.22222% with 30 lines in your changes missing coverage. Please review.

Project coverage is 40.38%. Comparing base (cfb6128) to head (cb355b8).

Files with missing lines Patch % Lines
packages/frontend/src/pages/admin/roles.editor.vue 0.00% 20 Missing ⚠️
packages/frontend/src/pages/admin/roles.vue 0.00% 8 Missing ⚠️
...cessors/CheckModeratorsActivityProcessorService.ts 95.34% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14974       +/-   ##
============================================
+ Coverage    18.81%   40.38%   +21.56%     
============================================
  Files          766     1609      +843     
  Lines       111337   210520    +99183     
  Branches      1234     4087     +2853     
============================================
+ Hits         20947    85015    +64068     
- Misses       89801   124865    +35064     
- Partials       589      640       +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 16, 2024

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -82755,6 +82755,9 @@
           },
           "canImportUserLists": {
             "type": "boolean"
+          },
+          "isModeratorInactivityCheckTarget": {
+            "type": "boolean"
           }
         },
         "required": [
@@ -82788,7 +82791,8 @@
           "canImportBlocking",
           "canImportFollowing",
           "canImportMuting",
-          "canImportUserLists"
+          "canImportUserLists",
+          "isModeratorInactivityCheckTarget"
         ]
       },
       "ReversiGameLite": {

Get diff files from Workflow Page

# Conflicts:
#	packages/backend/test/unit/queue/processors/CheckModeratorsActivityProcessorService.ts
#	pnpm-lock.yaml
@samunohito samunohito added this to the v2025.2.1 milestone Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
Development

Successfully merging this pull request may close these issues.

1 participant