-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 特定ロールポリシーによる運営アクティビティの検知範囲拡大に対応 #14974
Open
samunohito
wants to merge
5
commits into
misskey-dev:develop
Choose a base branch
from
samunohito:feature/13437-ex-activity-user
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: 特定ロールポリシーによる運営アクティビティの検知範囲拡大に対応 #14974
samunohito
wants to merge
5
commits into
misskey-dev:develop
from
samunohito:feature/13437-ex-activity-user
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14974 +/- ##
============================================
+ Coverage 18.81% 40.38% +21.56%
============================================
Files 766 1609 +843
Lines 111337 210520 +99183
Branches 1234 4087 +2853
============================================
+ Hits 20947 85015 +64068
- Misses 89801 124865 +35064
- Partials 589 640 +51 ☔ View full report in Codecov by Sentry. |
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -82755,6 +82755,9 @@
},
"canImportUserLists": {
"type": "boolean"
+ },
+ "isModeratorInactivityCheckTarget": {
+ "type": "boolean"
}
},
"required": [
@@ -82788,7 +82791,8 @@
"canImportBlocking",
"canImportFollowing",
"canImportMuting",
- "canImportUserLists"
+ "canImportUserLists",
+ "isModeratorInactivityCheckTarget"
]
},
"ReversiGameLite": { |
# Conflicts: # packages/backend/test/unit/queue/processors/CheckModeratorsActivityProcessorService.ts # pnpm-lock.yaml
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
packages/backend:test
packages/backend
Server side specific issue/PR
packages/frontend
Client side specific issue/PR
packages/misskey-js
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
運営アクティビティの検知範囲は「rootユーザであること」「モデレータ以上の権限を有するロールにアサインされていること」に限られていましたが、非モデレータロールでも特定のポリシーを有するロールにアサインされていればアクティビティの検知対象とするようにしました。
デフォルト値はfalseなので、明示的に有効化しない限りは機能しません。
Why
#13437 の対応
Additional info (optional)
Checklist