Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(backend): 連合する必要のないプロフィール項目しか更新されなかった場合にはUpdateアクティビティを発行しないように #14301

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Jul 25, 2024

What

書いてあるとおり

Why

#13820 対策(意味があるかどうかは不明)

Additional info (optional)

連合に必要なkeyを「連合に必要なkeyリスト」に登録していないままその値を連合に使用しようとすると型エラーが起こるようにしてある(はず)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jul 25, 2024
Copy link
Contributor

github-actions bot commented Jul 25, 2024

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@kakkokari-gtyih
Copy link
Contributor Author

多分動くとは思うので要りそうならどうぞ

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 50 lines in your changes missing coverage. Please review.

Project coverage is 39.38%. Comparing base (8a4ce16) to head (ebf436d).

Files with missing lines Patch % Lines
...kages/backend/src/server/api/endpoints/i/update.ts 10.25% 35 Missing ⚠️
.../backend/src/core/activitypub/ApRendererService.ts 18.75% 13 Missing ⚠️
packages/backend/src/misc/prelude/object.ts 75.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14301      +/-   ##
===========================================
- Coverage    39.47%   39.38%   -0.10%     
===========================================
  Files         1559     1560       +1     
  Lines       196958   197036      +78     
  Branches      3561     3563       +2     
===========================================
- Hits         77750    77598     -152     
- Misses      118602   118830     +228     
- Partials       606      608       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review July 25, 2024 07:40
@kakkokari-gtyih
Copy link
Contributor Author

フロントエンド側で更新されていない値もpayloadに含むような仕様になってるのならこれは意味をなさない可能性がある(フロントエンドで変わってない値のプロパティを弾くか、バックエンドで今の値と入ってきた値の比較をする処理が必要かもしれない)

@syuilo
Copy link
Member

syuilo commented Jul 30, 2024

フロントエンド側で更新されていない値もpayloadに含むような仕様になってるのなら

なってた気がする

@kakkokari-gtyih
Copy link
Contributor Author

うーん

@kakkokari-gtyih kakkokari-gtyih marked this pull request as draft July 30, 2024 09:08
@kakkokari-gtyih
Copy link
Contributor Author

backendにdeepEqualが必要

@kakkokari-gtyih
Copy link
Contributor Author

backendにdeepEqualが必要

node標準が使えた

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review September 6, 2024 08:18
@kakkokari-gtyih
Copy link
Contributor Author

tabun ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

2 participants