Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom dimension 1 support to the Event class #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kimblebrook
Copy link

Events can be used to submit optional custom dimension values. I've added an optional custom1 dimension to the Event payload to support this. Since you can have a number of custom dimensions, I am planning to enhance this to use a list, but wanted to get this PR in first. Feedback and suggestions welcome!

PS: I love this library, so thanks so much for making it!

@codecov-io
Copy link

Current coverage is 88.53%

Merging #11 into master will decrease coverage by -1.14% as of af6bc3a

@@            master     #11   diff @@
======================================
  Files            1       1       
  Stmts          155     157     +2
  Branches        37      38     +1
  Methods          0       0       
======================================
  Hit            139     139       
- Partial          8       9     +1
- Missed           8       9     +1

Review entire Coverage Diff as of af6bc3a

Powered by Codecov. Updated on successful CI builds.

@patrys
Copy link
Contributor

patrys commented Mar 7, 2016

Since it changes the API, I'd rather merge it in its final form to avoid changing the API twice. Would you mind sharing what you'd want the final API to look like? I think a tuple would make more sense than a list since it's the positions that matter, not the order (you always want metric n to represent the same thing).

@Kimblebrook
Copy link
Author

That makes a lot of sense, @patrys. I'll have a think about it and also look into the tuple too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants