respect convert_to_snake_case settings #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rafalp would you be able to take a look at this whenever you get a chance? very minor change |
|
Hi @Rosswell, @DamianCzajkowski is the man you want. I am no longer with Mirumee and I have no powers here anymore :D |
|
Hi @Rosswell, could you add a changelog entry? |
|
@DamianCzajkowski done! |
DamianCzajkowski
approved these changes
Aug 9, 2024
|
I've checked it, and it looks fine. Just some linters failed, so after you resolve them, I will merge it and deploy a new version. |
|
@DamianCzajkowski fixed :) |
|
Appreciate this feature - it solved my problem! I look forward to it being deployed. In the mean time I successfully got it from git. I think the default feature is still broken though - Generated code works fine with the snake case. It breaks when trying to get nested properties. Either way thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #275 by passing the
convert_to_snake_caseto various generators created via theget_package_generatorfunction.adds a test that attempts to test that all the generator class fields that are determined by data passed in from
ClientSettingsare respected.tested both via unit tests and by regenerating code in which i experienced this issue myself