Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect convert_to_snake_case settings #307

Merged
merged 4 commits into from
Aug 10, 2024

Conversation

Rosswell
Copy link
Contributor

fixes #275 by passing the convert_to_snake_case to various generators created via the get_package_generator function.

adds a test that attempts to test that all the generator class fields that are determined by data passed in from ClientSettings are respected.

tested both via unit tests and by regenerating code in which i experienced this issue myself

@Rosswell
Copy link
Contributor Author

Rosswell commented Aug 5, 2024

@rafalp would you be able to take a look at this whenever you get a chance? very minor change

@rafalp
Copy link
Contributor

rafalp commented Aug 5, 2024

Hi @Rosswell, @DamianCzajkowski is the man you want.

I am no longer with Mirumee and I have no powers here anymore :D

@DamianCzajkowski
Copy link
Contributor

Hi @Rosswell, could you add a changelog entry?

@Rosswell
Copy link
Contributor Author

Rosswell commented Aug 8, 2024

@DamianCzajkowski done!

@DamianCzajkowski
Copy link
Contributor

I've checked it, and it looks fine. Just some linters failed, so after you resolve them, I will merge it and deploy a new version.

@Rosswell
Copy link
Contributor Author

Rosswell commented Aug 9, 2024

@DamianCzajkowski fixed :)

@DamianCzajkowski DamianCzajkowski merged commit 11bfe35 into mirumee:main Aug 10, 2024
4 checks passed
@McleanWorkshield
Copy link

Appreciate this feature - it solved my problem!

I look forward to it being deployed. In the mean time I successfully got it from git.

I think the default feature is still broken though - Generated code works fine with the snake case. It breaks when trying to get nested properties.

Either way thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client methods for queries and mutation names do not respect convert_to_snake_case = false
4 participants